After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 654977 - Nicer search results layout
Nicer search results layout
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: shell
3.0.x
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
: 654694 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-07-20 15:47 UTC by Allan Day
Modified: 2012-05-22 15:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Settings search mockup (61.75 KB, image/png)
2011-07-20 15:47 UTC, Allan Day 		  Details
Implement a new search results design (6.23 KB, patch)
2012-05-22 03:03 UTC, William Jon McCann 		committed Details | Review

Description Allan Day 2011-07-20 15:47:58 UTC 
Created attachment 192314 [details]
Settings search mockup

Search results aren't laid out evenly and they are packed together too tightly. Also, panel descriptions are truncated. There is plenty of space available, we might as well use it.

A mockup for a new layout is attached. This got a +1 from jimmac and hbons on IRC.
Comment 1 Matthias Clasen 2011-07-21 04:09:54 UTC 
Looks nice. And has been complained about before, too
Comment 2 Matthias Clasen 2011-07-21 04:10:07 UTC 
*** Bug 654694 has been marked as a duplicate of this bug. ***
Comment 3 Matthias Clasen 2012-05-01 02:01:07 UTC 

*** This bug has been marked as a duplicate of bug 673869 ***
Comment 4 Bastien Nocera 2012-05-17 14:43:03 UTC 
I think we want those specific UI changes for the search.
Comment 5 William Jon McCann 2012-05-22 03:03:14 UTC 
Created attachment 214627 [details] [review]
Implement a new search results design

Search results aren't laid out evenly and they are packed together too tightly.
Also, panel descriptions are truncated. There is plenty of space available, we
might as well use it.
Comment 6 William Jon McCann 2012-05-22 03:04:40 UTC 
One thing that I haven't done is set the description text to be dim. I think it might make sense to use a css class for this so it works in themes. I've opened bug 676536 for this.
Comment 7 Bastien Nocera 2012-05-22 14:30:31 UTC 
Review of attachment 214627 [details] [review]:

You should also remove the now unused search_renderer struct member.

::: shell/gnome-control-center.c
@@ +594,3 @@
+  char         *id = NULL;
+
+  if (gtk_tree_selection_get_selected (selection, &model, &iter))

if (!gtk_tree_selection_get_selected ())
  return;
would be better.
Comment 8 William Jon McCann 2012-05-22 15:44:46 UTC 
Attachment 214627 [details] pushed as e18742c - Implement a new search results design