After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 654953 - Fetch Notes in contact
Fetch Notes in contact
Status: RESOLVED FIXED
Product: evolution-ews
Classification: Other
Component: Contacts (personal addressbooks)
3.6.x
Other Linux
: Normal enhancement
: ---
Assigned To: Evolution EWS maintainer(s)
Evolution EWS maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2011-07-20 10:00 UTC by Akhil Laddha
Modified: 2013-03-14 17:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Bug 654953 - Fetch Notes in contact (6.32 KB, patch)
2013-03-14 14:45 UTC, Fabiano Fidêncio 		needs-work Details | Review

Description Akhil Laddha 2011-07-20 10:00:20 UTC 
EWS + Exchange 2007

1. Create a contact in outlook
2. Add note and attach a file
3. Save in personal address book
4. Fetch contact in evolution
5. Evolution won't show any note or attached file
Comment 1 Milan Crha 2013-03-12 08:42:11 UTC 
Downstream bug report from 3.6.3 about the Notes:
https://bugzilla.redhat.com/show_bug.cgi?id=920363

Evolution doesn't support attachments on Contacts, hence I'd say fetch the Notes at least.
Comment 2 Fabiano Fidêncio 2013-03-14 14:45:11 UTC 
Created attachment 238880 [details] [review]
Bug 654953 - Fetch Notes in contact
Comment 3 Milan Crha 2013-03-14 16:56:12 UTC 
Review of attachment 238880 [details] [review]:

Works fine, except one thing below. Fix it and commit, thanks.

::: src/addressbook/e-book-backend-ews.c
@@ +851,3 @@
+		return;
+
+	if (g_ascii_strcasecmp (old_notes, new_notes)) {

Only here two things:
a) do not use case insensitive checking
b) if any of these can be NULL, then there should be a test for it (though for me there wasn't NULL, it seems)