After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 654945 - x264enc: implement new force-key-unit API
x264enc: implement new force-key-unit API
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-ugly
git master
Other All
: Normal enhancement
: 0.10.20
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on: 607742
Blocks:
 
 
Reported: 2011-07-20 07:27 UTC by Alessandro Decina
Modified: 2012-02-18 20:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (3.63 KB, patch)
2011-07-20 07:27 UTC, Alessandro Decina 		needs-work Details | Review
patch resetting segment on state change and flush (4.10 KB, patch)
2011-07-20 21:38 UTC, Alessandro Decina 		none Details | Review
updated patch (10.51 KB, application/octet-stream)
2011-09-15 23:02 UTC, Alessandro Decina 		  Details
updated patch (10.51 KB, patch)
2011-09-15 23:07 UTC, Alessandro Decina 		none Details | Review

Description Alessandro Decina 2011-07-20 07:27:01 UTC 
Created attachment 192275 [details] [review]
patch

As per summary
Comment 1 Olivier Crête 2011-07-20 17:08:09 UTC 
Review of attachment 192275 [details] [review]:

Don't you need to flush the segment on state change and flush stop too ?
Comment 2 Alessandro Decina 2011-07-20 21:38:56 UTC 
Created attachment 192341 [details] [review]
patch resetting segment on state change and flush
Comment 3 Alessandro Decina 2011-07-20 21:39:34 UTC 
Yep, new patch attached
Comment 4 Alessandro Decina 2011-09-15 23:02:07 UTC 
Created attachment 196680 [details]
updated patch

New iteration. Now using the running time to decide when to output a keyframe.
Comment 5 Alessandro Decina 2011-09-15 23:07:24 UTC 
Created attachment 196682 [details] [review]
updated patch

New iteration. Now using the running time to decide when to output a keyframe.
Comment 6 David Schleef 2012-01-24 01:23:42 UTC 
Looks good.  Has this been pushed?
Comment 7 Alessandro Decina 2012-01-26 18:45:41 UTC 
commit 4322fd07523669c9566ca567b02252380ec38df3
Author: Alessandro Decina <alessandro.d@gmail.com>
Date:   Wed Jul 20 09:00:58 2011 +0200

    x264enc: implement force-key-unit API