After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 654855 - partial: Keep building when a system dependency transitions from too old -> new enough
partial: Keep building when a system dependency transitions from too old -> n...
Status: RESOLVED FIXED
Product: jhbuild
Classification: Infrastructure
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on:
Blocks:
 
 
Reported: 2011-07-18 16:00 UTC by Colin Walters
Modified: 2011-07-18 18:38 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Move 'packagedb' from Buildscript into Moduleset (21.55 KB, patch)
2011-07-18 18:05 UTC, Colin Walters
none Details | Review
moduleset: Only skip system dependencies if we haven't done a build before (1.34 KB, patch)
2011-07-18 18:05 UTC, Colin Walters
committed Details | Review

Description Colin Walters 2011-07-18 16:00:30 UTC
As owen mentioned in https://bugzilla.gnome.org/show_bug.cgi?id=564373#c66 , if we're in partial_build mode, we need to keep building a module if we've ever built it, even if the system dependency is now new enough.

To implement this we need access to the packagedb inside the moduleset parser, which implies taking it out of buildscript.py.
Comment 1 Colin Walters 2011-07-18 18:05:13 UTC
Created attachment 192209 [details] [review]
Move 'packagedb' from Buildscript into Moduleset

The moduleset needs access to the packagedb for issues such as (see bug 654855).
Comment 2 Colin Walters 2011-07-18 18:05:16 UTC
Created attachment 192210 [details] [review]
moduleset: Only skip system dependencies if we haven't done a build before

If we're in partial_build mode, we need to keep building a module if
we've ever built it, even if the system dependency is now new enough.
An example is where one is using jhbuild and has built dbus, but then
one upgrades the distro, and a new enough system dbus comes in.
Comment 3 Colin Walters 2011-07-18 18:38:28 UTC
Attachment 192210 [details] pushed as 5e333b6 - moduleset: Only skip system dependencies if we haven't done a build before