After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 654791 - telepathyClient: a few fixes
telepathyClient: a few fixes
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: message-tray
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-07-17 19:26 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2011-07-17 22:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
telepathyClient: Fix undefined variable (1005 bytes, patch)
2011-07-17 19:26 UTC, Jasper St. Pierre (not reading bugmail)
committed Details | Review
telepathyClient: Code cleanup (2.10 KB, patch)
2011-07-17 19:26 UTC, Jasper St. Pierre (not reading bugmail)
committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2011-07-17 19:26:50 UTC
see patches
Comment 1 Jasper St. Pierre (not reading bugmail) 2011-07-17 19:26:52 UTC
Created attachment 192139 [details] [review]
telepathyClient: Fix undefined variable
Comment 2 Jasper St. Pierre (not reading bugmail) 2011-07-17 19:26:56 UTC
Created attachment 192140 [details] [review]
telepathyClient: Code cleanup

Move a function to where it's used and rename "_createSource"
to reflect that it creates *chat* sources.
Comment 3 Jasper St. Pierre (not reading bugmail) 2011-07-17 22:59:44 UTC
Attachment 192139 [details] pushed as bf2ba83 - telepathyClient: Fix undefined variable
Attachment 192140 [details] pushed as 80b98d8 - telepathyClient: Code cleanup