After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 654729 - MetaTextureTower: Remove workaround for old clutter bug
MetaTextureTower: Remove workaround for old clutter bug
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2011-07-16 11:30 UTC by drago01
Modified: 2011-07-16 12:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
MetaTextureTower: Remove workaround for old clutter bug (1.16 KB, patch)
2011-07-16 11:30 UTC, drago01 		committed Details | Review

Description drago01 2011-07-16 11:30:37 UTC 
See patch
Comment 1 drago01 2011-07-16 11:30:39 UTC 
Created attachment 192082 [details] [review]
MetaTextureTower: Remove workaround for old clutter bug

texture_tower_revalidate_fbo() called cogl_flush() to work around
clutter bug #2110, which has been long fixed.

As we depend on clutter 1.7.x anyway we can just remove that workaround.
Comment 2 Florian Müllner 2011-07-16 12:21:23 UTC 
Review of attachment 192082 [details] [review]:

Good to commit with the style fix pointed out below:

::: src/compositor/meta-texture-tower.c
@@ +433,1 @@
       tower->fbos[level] = cogl_offscreen_new_to_texture (dest_texture);

Wrong indentation after removing the braces.
Comment 3 drago01 2011-07-16 12:26:41 UTC 
Comment on attachment 192082 [details] [review]
MetaTextureTower: Remove workaround for old clutter bug

Commited with fixed indentation.