After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 654522 - Don't fail builds if the manifest is not set
Don't fail builds if the manifest is not set
Status: RESOLVED FIXED
Product: jhbuild
Classification: Infrastructure
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on:
Blocks:
 
 
Reported: 2011-07-13 03:26 UTC by Matthias Clasen
Modified: 2011-07-13 18:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.43 KB, patch)
2011-07-13 03:26 UTC, Matthias Clasen 		none Details | Review

Description Matthias Clasen 2011-07-13 03:26:22 UTC 
Created attachment 191858 [details] [review]
patch

When the module has not been updated, we may call the matches function with a files_list of None. This should not fail the build. My build slave was immediately hitting this after updating to the triggers changes.
Comment 1 Colin Walters 2011-07-13 13:39:55 UTC 
This is caused by you having an old jhbuild packagedb.xml which doesn't have an installed manifest.  You basically need to blow away the root and rerun the build.

I will however make jhbuild not crash in this scenario.
Comment 2 Matthias Clasen 2011-07-13 18:00:45 UTC 
Can I suggest that if you commit changes to jhbuild that require everybody to 'blow away the root', it would be a good idea to send a note about this to ddl ?
Comment 3 Colin Walters 2011-07-13 18:12:29 UTC 
(In reply to comment #2)
> Can I suggest that if you commit changes to jhbuild that require everybody to
> 'blow away the root', it would be a good idea to send a note about this to ddl
> ?

Absolutely, one is overdue =(  However I didn't intend to *require* it, just that it's a good idea.  And I did push a fix which should solve the issue you hit here.