After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 654489 - fix a crash-on-exit
fix a crash-on-exit
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2011-07-12 17:08 UTC by Dan Winship
Modified: 2011-07-12 17:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix a crash-on-exit (1.14 KB, patch)
2011-07-12 17:08 UTC, Dan Winship 		committed Details | Review

Description Dan Winship 2011-07-12 17:08:02 UTC 
meta_frames_destroy() was not safe to be called multiple times, which
was causing a crash on exit due to something else changing somewhere
that makes it get called multiple times.
Comment 1 Dan Winship 2011-07-12 17:08:04 UTC 
Created attachment 191825 [details] [review]
fix a crash-on-exit
Comment 2 Florian Müllner 2011-07-12 17:12:05 UTC 
Review of attachment 191825 [details] [review]:

Looks good.

::: src/ui/frames.c
@@ +317,3 @@
+    {
+      g_object_unref (frames->normal_style);
+      frames->normal_style = NULL;

I think we already depend on glib 2.28, so you could use g_object_clear(). On the other hand it would break the symmetry with the hash table, so well ...
Comment 3 Dan Winship 2011-07-12 17:53:40 UTC 
Attachment 191825 [details] pushed as d2b63ea - fix a crash-on-exit