GNOME Bugzilla – Bug 654485
Parsing modulation from DVB satellite delivery descriptors
Last modified: 2012-06-21 09:59:04 UTC
Created attachment 191821 [details] [review] Fix satellite delivery descriptor parsing (against HEAD). The way modulation settings are set when parsing DVB satellite delivery descriptors doesn't seem to match ETSI EN 300 468. I think the problem is mainly that the switch was apparently copy & pasted from the code for cable descriptors and not amended. I've corrected the parsing and added support for 8PSK to dvbsrc.
Created attachment 191822 [details] [review] Fix satellite delivery descriptor parsing (against s2api). Version of the patch to be applied after my s2api patch from Bug 654479.
Please create patches using 'git format-patch'. This retains the author and changelog information, as well as often making merges easier.
Created attachment 191909 [details] [review] Correct satellite delivery descriptor parsing (standalone) Standalone version of the patch. Now generated with git format-patch.
Created attachment 191911 [details] [review] Correct satellite delivery descriptor parsing (DVB-S2 version) To be applied after patch 191903 and optionally after patch 191904.
(In reply to comment #4) > Created an attachment (id=191911) [details] [review] > Correct satellite delivery descriptor parsing (DVB-S2 version) > > To be applied after patch 191903 [details] and optionally after patch 191904 [details]. This is the same version of the patch in comment 3. Thanks ! commit 07dd35ad73cae9f79f2fac28a38ef2592ebb53a1 Author: Tony Houghton <h@realh.co.uk> Date: Wed Jul 13 19:25:08 2011 +0100 Correct satellite delivery descriptor parsing. Original code to parse satellite delivery descriptors to generate "satellite" structures appeared to be copy & pasted from cable's code without amending for satellite. Also added 8PSK to dvbsrc's enum for modulation. https://bugzilla.gnome.org/show_bug.cgi?id=654485