After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 654444 - fix bsd detection
fix bsd detection
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: general
3.0.x (obsolete)
Other OpenBSD
: Normal normal
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2011-07-12 09:24 UTC by Antoine Jacoutot
Modified: 2011-07-12 12:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix configure.ac for BSDs (1.58 KB, patch)
2011-07-12 09:24 UTC, Antoine Jacoutot 		committed Details | Review

Description Antoine Jacoutot 2011-07-12 09:24:20 UTC 
Created attachment 191795 [details] [review]
fix configure.ac for BSDs

Hi.

This patch does 2 things on OpenBSD and FreeBSD:
* move down the $host check because currently when this check is run, $host is not defined
* do not use libdl, it is not available

Thoughts?
Comment 1 Jasper Lievisse Adriaanse 2011-07-12 09:31:03 UTC 
I concur this is correct; Can I push it?
Comment 2 Matthew Barnes 2011-07-12 10:25:51 UTC 
Okay by me to push.  I assume AC_CANONICAL_HOST is what defines $host?  If so, can you add a little comment where $host is first used saying something like "This must appear after AC_CANONICAL_HOST, which defines $host", just so this doesn't accidentally break again?
Comment 3 Jasper Lievisse Adriaanse 2011-07-12 11:27:33 UTC 
Yes, AC_CANONICAL_HOST is indeed what defines $host. I've added the comment and committed it as: http://git.gnome.org/browse/evolution-data-server/commit/?id=27e8a5713a345fc276deb74daa26e982bd87dec7
Comment 4 Matthew Barnes 2011-07-12 12:26:25 UTC 
Thanks!