After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 654363 - uprof: Add the units in the name of the "Per Frame" timer attribute
uprof: Add the units in the name of the "Per Frame" timer attribute
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks:
 
 
Reported: 2011-07-11 01:05 UTC by Damien Lespiau
Modified: 2011-07-12 10:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
uprof: Add the units in the name of the "Per Frame" timer attribute (1.11 KB, patch)
2011-07-11 01:05 UTC, Damien Lespiau 		reviewed Details | Review
uprof: Add the units in the name of the "Per Frame" timer attribute (1.36 KB, patch)
2011-07-11 12:41 UTC, Damien Lespiau 		committed Details | Review

Description Damien Lespiau 2011-07-11 01:05:32 UTC 
So it shows up in the profile report.
Comment 1 Damien Lespiau 2011-07-11 01:05:35 UTC 
Created attachment 191662 [details] [review]
uprof: Add the units in the name of the "Per Frame" timer attribute
Comment 2 Emmanuele Bassi (:ebassi) 2011-07-11 06:37:55 UTC 
Review of attachment 191662 [details] [review]:

::: clutter/clutter-profile.c
@@ +208,2 @@
                                      "Per Frame",
                                      "The amount of timer per frame",

can we also fix "The amount of timer per frame", please?
Comment 3 Damien Lespiau 2011-07-11 12:41:21 UTC 
Created attachment 191709 [details] [review]
uprof: Add the units in the name of the "Per Frame" timer attribute

So it shows up in the profile report. Take the opportunity to write a
better long description for the attribute.
Comment 4 Emmanuele Bassi (:ebassi) 2011-07-11 17:04:44 UTC 
Review of attachment 191709 [details] [review]:

looks okay now.
Comment 5 Damien Lespiau 2011-07-12 10:03:18 UTC 
Attachment 191709 [details] pushed as 25a7435 - uprof: Add the units in the name of the "Per Frame" timer attribute