After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 654310 - FAAC VBR encoding support
FAAC VBR encoding support
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
0.10.x
Other Linux
: Normal normal
: 0.10.23
Assigned To: David Schleef
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-07-09 19:59 UTC by Mukul Majmudar
Modified: 2011-07-10 00:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch to add the feature requested by the bug (5.65 KB, patch)
2011-07-09 20:20 UTC, Mukul Majmudar 		rejected Details | Review

Description Mukul Majmudar 2011-07-09 19:59:26 UTC 
VBR encoding using FAAC is not available in gstreamer, whereas libfaac has support for it.
Comment 1 Mukul Majmudar 2011-07-09 20:20:40 UTC 
Created attachment 191591 [details] [review]
Proposed patch to add the feature requested by the bug

The proposed patch adds two new properties: "quality" and "brtype", corresponding to VBR quantizer quality and encoding bitrate type, respectively. VBR or ABR encoding can be selected using the "brtype" property. The default bitrate type has been set to VBR, and the default VBR quality to 100, as in the FAAC command-line program.
Comment 2 David Schleef 2011-07-09 20:24:41 UTC 
Looks good.  will commit when i get a chance.
Comment 3 David Schleef 2011-07-10 00:21:23 UTC 
Changed the property name to "rate-control".

commit 932dee92842e94d0e0c70eb1d96c0be698d2e144
Author: Mukul Majmudar <mukul.majmudar@gmail.com>
Date:   Sat Jul 9 16:05:07 2011 -0400

    faac: Add properties for VBR encoding
    
    Property "quality" to specify VBR quantizer quality and property
    "brtype" to choose between ABR and VBR encoding. The default is now VBR
    with quality=100.
    
    Fixes bug #654310.
    
    Signed-off-by: David Schleef <ds@schleef.org>