After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 654267 - [Patch] PopupSwitchMenuItem overrides its internal switch at creation
[Patch] PopupSwitchMenuItem overrides its internal switch at creation
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.1.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-07-08 19:16 UTC by Marc-Antoine Perennou
Modified: 2011-07-09 23:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
PopupSwitchMenuItem: don't override switch by creating it twice (953 bytes, patch)
2011-07-08 19:17 UTC, Marc-Antoine Perennou 		committed Details | Review

Description Marc-Antoine Perennou 2011-07-08 19:16:32 UTC 
Currently, initialisation make a
this._switch = new Switch(active);
and then a
this._switch = new Switch(false);
Causing the switch to always be set to false at the creation of a PopupSwitchMenuItem
Comment 1 Marc-Antoine Perennou 2011-07-08 19:17:35 UTC 
Created attachment 191532 [details] [review]
PopupSwitchMenuItem: don't override switch by creating it twice
Comment 2 Florian Müllner 2011-07-08 22:57:46 UTC 
Review of attachment 191532 [details] [review]:

LGTM
Comment 3 Jasper St. Pierre (not reading bugmail) 2011-07-09 23:30:04 UTC 
Attachment 191532 [details] pushed as 6d53d43 - PopupSwitchMenuItem: don't override switch by creating it twice


Pushed with revised commit message as discussed on IRC.