After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 654216 - vp8enc: tag invisible frames
vp8enc: tag invisible frames
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal enhancement
: 1.0.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-07-08 06:45 UTC by Oleksij Rempel
Modified: 2012-10-23 15:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
vp8-add-codec-specific-flags-for-gst-intern-use.patch (996 bytes, patch)
2011-07-08 06:45 UTC, Oleksij Rempel 		rejected Details | Review
0005-vp8enc-mark-invisible-frame-with-flag-GST_BUFFER_FLA.patch (879 bytes, patch)
2011-07-08 06:46 UTC, Oleksij Rempel 		needs-work Details | Review
patch fot gst-1.0 (834 bytes, patch)
2012-10-02 18:54 UTC, Oleksij Rempel 		committed Details | Review

Description Oleksij Rempel 2011-07-08 06:45:56 UTC 
Created attachment 191506 [details] [review]
vp8-add-codec-specific-flags-for-gst-intern-use.patch

vp8: add codec specific flags for gst intern use.
    
    Add INVISIBLE and DROPPABLE flags to use it at least for debuging.
    May be some more use cases will be later.
Comment 1 Oleksij Rempel 2011-07-08 06:46:33 UTC 
Created attachment 191507 [details] [review]
0005-vp8enc-mark-invisible-frame-with-flag-GST_BUFFER_FLA.patch
Comment 2 Tim-Philipp Müller 2012-02-14 21:17:31 UTC 
This would *probably* work, but it's a bit dodgy imho. Buffer flags like that are meant for buffer subclasses.

An alternative (though slightly more expensive) way of tagging such buffers would be using the new gst_buffer_set_qdata() API.

Don't know if others have an opinion on what's better.
Comment 3 Sebastian Dröge (slomo) 2012-09-16 08:35:03 UTC 
These patches are for 0.10, could you update them to 0.11/1.0? There these buffer flags already exist in core.
Comment 4 Oleksij Rempel 2012-10-02 18:54:35 UTC 
Created attachment 225610 [details] [review]
patch fot gst-1.0

Here is updated patch for gst-1.0
Comment 5 Tim-Philipp Müller 2012-10-23 15:16:55 UTC 
commit 83a47cdd0e2be9e50be787e9f082d80984972293
Author: Oleksij Rempel <bug-track@fisher-privat.net>
Date:   Tue Oct 2 20:51:29 2012 +0200

    vp8enc: set DECODE_ONLY flag on invisible AltRef frames
    
    https://bugzilla.gnome.org/show_bug.cgi?id=654216