Created attachment 191439 [details] [review]
Display the number of unread messages in the notification icon

I got this when using my patch:

    JS ERROR: !!!   Exception was: Error: Invalid notification count: 0
    JS ERROR: !!!     lineNumber = '945'
    JS ERROR: !!!     fileName = '"/home/cassidy/usr/share/gnome-shell/js/ui/messageTray.js"'
    JS ERROR: !!!     stack = '"Error("Invalid notification count: 0")@:0



I think the problem is in _setCount(), it shouldn't raise an error if we pass 0.
What's the point of this call actually? _setCount is supposed to take an int already.

It's checking that @count actually is a number, because if we don't, then some extension is going to do _setCount("Blah blah blah here is some tooltip text that I'm putting in the icon since I can't use a tooltip", true). The fact that it doesn't let "0" through is a bug.

Created attachment 191449 [details] [review]
messageTray.js: don't raise an exception if count equals 0

Review of attachment 191449 [details] [review]:

::: js/ui/messageTray.js
@@ +943,2 @@
     _setCount: function(count, visible) {
+        if (count != 0 && !parseInt(count))

try if(isNaN(parseInt(count)))

Created attachment 191452 [details] [review]
messageTray.js: don't raise an exception if count equals 0

Created attachment 191453 [details] [review]
messageTray.js: raise an exception only if parseInt(count) returns NaN

0 is a valid value for count so we should accept it.

Review of attachment 191453 [details] [review]:

sure.

Attachment 191439 [details] pushed as fda8ffd - Display the number of unread messages in the notification icon
Attachment 191453 [details] pushed as 6cb707c - messageTray.js: raise an exception only if parseInt(count) returns NaN