After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 654105 - workspace: Fix layout errors caused by window zoom
workspace: Fix layout errors caused by window zoom
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-07-06 16:01 UTC by Florian Müllner
Modified: 2011-07-06 20:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
workspace: Fix layout errors caused by window zoom (1.78 KB, patch)
2011-07-06 16:01 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2011-07-06 16:01:21 UTC 
Some fallout from the layout changes introduced in bug 636963, see attached patch.
Comment 1 Florian Müllner 2011-07-06 16:01:23 UTC 
Created attachment 191411 [details] [review]
workspace: Fix layout errors caused by window zoom

Commit 64b2b4a7d4 changed the monitor layout handling, resulting
in some layout errors due to a subtle change in memory handling:
when zooming a window in the overview, the available zoom area is
calculated by subtracting the panel height from the primary monitor
area. This area used to be a copy of the monitor rect, but as now
the rect itself is returned, zooming a window on the primary monitor
repeatedly modifies the monitor rect, leading to layout errors in
various parts of the shell.
Fix by using a copy when calculating the available zoom area.
Comment 2 Owen Taylor 2011-07-06 19:19:30 UTC 
Review of attachment 191411 [details] [review]:

Seems fine
Comment 3 Florian Müllner 2011-07-06 20:07:25 UTC 
Attachment 191411 [details] pushed as 8d1b796 - workspace: Fix layout errors caused by window zoom