After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 653685 - keyboard: Change precedence for schema in KeyList parser
keyboard: Change precedence for schema in KeyList parser
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Keyboard
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-06-29 23:02 UTC by Florian Müllner
Modified: 2011-06-30 12:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
keyboard: Change precedence for schema in KeyList parser (1.44 KB, patch)
2011-06-29 23:02 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2011-06-29 23:02:47 UTC 
Briefly discussed this with Bastien on IRC, see attached patch.
Comment 1 Florian Müllner 2011-06-29 23:02:49 UTC 
Created attachment 190967 [details] [review]
keyboard: Change precedence for schema in KeyList parser

Right now, if both KeyList and KeyListEntry contain a schema element,
the (global) one of the list wins. This makes it rather cumbersome
to mix keys of different schemas in a single list, as rather than
using a default schema and specifying a different one where necessary,
every key needs its own schema element.
A quick IRC discussion suggests that the current precedence is rather
random, so change it to support this case.
Comment 2 Bastien Nocera 2011-06-30 10:13:59 UTC 
With the last commit message you mentioned on IRC, this is good to commit.
Comment 3 Florian Müllner 2011-06-30 12:00:25 UTC 
Attachment 190967 [details] pushed as 8a85834 - keyboard: Change precedence for schema in KeyList parser