GNOME Bugzilla – Bug 653661
[PATCH] Show in Unity too
Last modified: 2011-06-30 11:58:26 UTC
Created attachment 190943 [details] [review] Add Unity Unity is a registered XDG environment [1]. Unity uses the gnome-control-center so the .desktop file should add it to its OnlyShowIn value. This isn't particularly relevant this second, but will be once the patch in bug 653440 lands. Note that there are some panels that I did not add Unity to -- the printer and datetime panels. Unity will have its own versions of those. [1] http://standards.freedesktop.org/menu-spec/latest/apb.html
Review of attachment 190943 [details] [review]: Looks good apart from that one bit. ::: panels/sound/data/gnome-sound-applet.desktop.in @@ +10,3 @@ X-GNOME-Bugzilla-Bugzilla=GNOME X-GNOME-Bugzilla-Product=gnome-control-center X-GNOME-Bugzilla-Component=sound You removed an extraneous line, that needs to happen in a separate patch please.
(In reply to comment #0) > Created an attachment (id=190943) [details] [review] > Add Unity > > Unity is a registered XDG environment [1]. Unity uses the gnome-control-center > so the .desktop file should add it to its OnlyShowIn value. > > This isn't particularly relevant this second, but will be once the patch in bug > 653440 lands. > > Note that there are some panels that I did not add Unity to -- the printer and > datetime panels. Unity will have its own versions of those. I will note that we won't be making any changes to the way that panels are loaded upstream though, so if you want to have any kind of old panel (like system-config-printer) showing up in your control-center main page, you'll have to carry those patches yourself. The changes to the desktop files are fine though.
commit 30302acefac83ed2467d5c3caaf8bef8718b781a Author: Michael Terry <michael.terry@canonical.com> Date: Thu Jun 30 12:50:42 2011 +0100 Remove extraneous line from the sound applet .desktop file. commit 0a8669a5b579d5e4c93a2708a3ebb53efb6da175 Author: Michael Terry <michael.terry@canonical.com> Date: Thu Jun 30 12:38:07 2011 +0100 Add Unity to OnlyShowIn fields https://bugzilla.gnome.org/show_bug.cgi?id=653661