After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 653231 - pipeline: Don't trigger a change when binding the invalid texture target
pipeline: Don't trigger a change when binding the invalid texture target
Status: RESOLVED FIXED
Product: cogl
Classification: Platform
Component: CoglPipeline
1.6.x
Other Linux
: Normal normal
: ---
Assigned To: Cogl maintainer(s)
Cogl maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2011-06-23 13:58 UTC by Damien Lespiau
Modified: 2011-07-01 13:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't trigger a change when binding the invalid texture target (1.30 KB, patch)
2011-06-23 13:58 UTC, Damien Lespiau 		none Details | Review

Description Damien Lespiau 2011-06-23 13:58:28 UTC 
Created attachment 190510 [details] [review]
Don't trigger a change when binding the invalid texture target

When setting NULL as the new texture for a layer, the pipeline is also
notified that the texture target has changed from 2D to 0 (the "invalid"
texture target). It should not matter to leave the texture target alone
in that case.
Comment 1 Robert Bragg 2011-07-01 13:58:35 UTC 
thanks, this should be fixed in master now by:

commit 098a19380215104f4dcf3474b4155f2d1b04f03d
Author: Robert Bragg <robert@linux.intel.com>
Date:   Mon Jun 27 21:09:27 2011 +0100

    pipeline: Avoid reseting texture target for NULL textures
    
    When setting a NULL texture on a CoglPipeline we would also reset the
    texture target to a dummy value of 0. Reseting the target also had the
    effect of making fragends discard any associated program. In cases where
    the NULL texture was only transient until a replacement texture could be
    set we were re-running lots of redundant codegen and shader
    compilations.
    
    Signed-off-by: Neil Roberts <neil@linux.intel.com>