GNOME Bugzilla – Bug 653206
Minor enhancements to the extension-tool.
Last modified: 2011-07-13 19:04:14 UTC
Just some minor code maintenance to the tool.
Created attachment 190485 [details] [review] extension-tool: Use socket.gethostname() instead of an external process Minor code cleanup.
Created attachment 190486 [details] [review] extension-tool: Clean up code creator, update sample Update the sample to be more up to date with respect to Shell practices, and make it look a bit prettier. Additionally, change the file extract code so that it's easier to update and add new files later.
Review of attachment 190485 [details] [review]: Looks much better.
Review of attachment 190486 [details] [review]: Looks good, fine to commit with a that simple api fix. ::: src/gnome-shell-extension-tool.in @@ +49,3 @@ + text.opacity = 255; + + let monitor = global.get_primary_monitor(); Should be Main.layoutManager.primaryMonitor
Created attachment 191912 [details] [review] extension-tool: Clean up code creator, update sample Update the sample to be more up to date with respect to Shell practices, and make it look a bit prettier. Additionally, change the file extract code so that it's easier to update and add new files later.
Attachment 190485 [details] pushed as c8d5e0a - extension-tool: Use socket.gethostname() instead of an external process Attachment 191912 [details] pushed as 7a8a00c - extension-tool: Clean up code creator, update sample