GNOME Bugzilla – Bug 653177
Don't bail out when running on a different release
Last modified: 2013-04-01 11:37:10 UTC
FreeBSD has had this patch for a while: http://www.freebsd.org/cgi/cvsweb.cgi/ports/devel/libgtop/files/patch-src_daemon_server.c The problem is that on FreeBSD that packages for a certain release can be built on different release (right, Marcus?). Same goes for OpenBSD to a lesser extend, as a machine can be running 5.0-beta with a package for 4.9-current. Not to mention cross-compiling. This leads to differences in LIBGTOP_COMPILE_RELEASE and triggers the message and stops the application. While it's possible for FreeBSD and OpenBSD to keep maintaining this patch in our ports trees, would generalizing it to something like this make it Ok for inclusion in libgtop? Say, just an #ifdef dance for __NetBSD__ && __FreeBSD__ && __OpenBSD__ around _exit(1) ?
If it's a general desync problem, then improving the error message looks fine to me?
Like changing the error message to what FreeBSD does? That would be sane. What shall we do with the _exit(1). Should non-BSD keep hitting that, or can it be removed altogether since we have a clearer error message?
It seems there is another ticket related to the issue: #602666. Any objections to committing that patch to get rid of the message altogether?
I like the idea, obviously. The exit was a bit much,
*** Bug 602666 has been marked as a duplicate of this bug. ***
This patch makes sense, please push it.
Thanks, it's been pushed.