After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 653078 - Improve pager autohide commit don't work
Improve pager autohide commit don't work
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.0.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-06-21 07:38 UTC by ecyrbe
Modified: 2011-06-21 20:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
workspaces-view: Always update zoom on workspace changes (3.30 KB, patch)
2011-06-21 20:13 UTC, Florian Müllner 		committed Details | Review

Description ecyrbe 2011-06-21 07:38:48 UTC 
this commit : http://git.gnome.org/browse/gnome-shell/commit/?id=59a3e393f9dcae65a045617f2a63c96261ef6e1f

is not working here. The pager is still hidden when using more than one workspace (+1 empty). even with more than two.
however, when reloading (alt+f2 r) gnome-shell, it no more hidden when using more than one destop. so i think that there is something wrong with the update mecanism here...
Comment 1 Florian Müllner 2011-06-21 08:33:41 UTC 
How do you add workspaces? Dragging windows from the first workspace to the empty one (or vice-versa) autohiding updates correctly here.
Comment 2 ecyrbe 2011-06-21 08:52:47 UTC 
Good point! You caught it.

When dragging, it's working... but when using keyboard (ctrl+alt+shift+down or ctrl+alt+shift+up), that's not working!
Comment 3 Florian Müllner 2011-06-21 20:13:01 UTC 
Created attachment 190389 [details] [review]
workspaces-view: Always update zoom on workspace changes

With commit 59a3e393f9 whether the workspace pager should autohide
now depends on the number of workspaces. As we only track changes
to the number of workspaces while the overview is visible, we miss
changes in "normal mode", i.e. when creating a new workspace by
moving a window with ctrl-alt-shift-arrow; as a result, the pager's
autohiding might be incorrect when entering the overview after that.
As a fix, keep tracking changes to the workspaces when the overview
is hidden and update the zoom options.
Comment 4 Colin Walters 2011-06-21 20:23:09 UTC 
Review of attachment 190389 [details] [review]:

Looks fine to me.
Comment 5 Florian Müllner 2011-06-21 20:25:12 UTC 
Attachment 190389 [details] pushed as 52a3423 - workspaces-view: Always update zoom on workspace changes