After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 653048 - config: Set JHBUILD_PREFIX in environment
config: Set JHBUILD_PREFIX in environment
Status: RESOLVED FIXED
Product: jhbuild
Classification: Infrastructure
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on:
Blocks: 653050
 
 
Reported: 2011-06-20 20:38 UTC by Colin Walters
Modified: 2011-06-22 14:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
config: Set JHBUILD_PREFIX in environment (1021 bytes, patch)
2011-06-20 20:38 UTC, Colin Walters
committed Details | Review

Description Colin Walters 2011-06-20 20:38:10 UTC
This is useful for other tools to consume; for example, in my
.bashrc, I want to show:

[jhbuild=/src/build/jhbuild]

Also, my "metabuild" tool will use it as a default for $prefix.
Comment 1 Colin Walters 2011-06-20 20:38:11 UTC
Created attachment 190314 [details] [review]
config: Set JHBUILD_PREFIX in environment
Comment 2 Craig Keogh 2011-06-22 02:34:12 UTC
Thank you for the patch. I don't understand. Why do you want your .bashrc to show the prefix? prefix is rarely changed. Is metabuild tool only used by you? If so, why upstream this?
Comment 3 Colin Walters 2011-06-22 03:02:03 UTC
(In reply to comment #2)
> Thank you for the patch. I don't understand. Why do you want your .bashrc to
> show the prefix? prefix is rarely changed.

I actually do use two separate prefixes sometimes, one for GNOME and one just for dbus and dbus-glib.  Rationale: building libdbus in your GNOME root as we all know means lots of manual futzing.

>  Is metabuild tool only used by you?

Currently maybe =)

> If so, why upstream this?

I think it's just generally useful; besides the bash prompt and metabuild, simply telling people to e.g.:

rm $JHBUILD_PREFIX/lib/*.la -rf 

or whatever can always work.
Comment 4 Craig Keogh 2011-06-22 04:04:00 UTC
Review of attachment 190314 [details] [review]:

(In reply to comment #3)
> I actually do use two separate prefixes sometimes, one for GNOME and one just
> for dbus and dbus-glib.  Rationale: building libdbus in your GNOME root as we
> all know means lots of manual futzing.

Ok, I understand now.

> I think it's just generally useful; besides the bash prompt and metabuild,
> simply telling people to e.g.:
> 
> rm $JHBUILD_PREFIX/lib/*.la -rf 
> 

This won't work. You'd have to tell people:

jhbuild run rm $JHBUILD_PREFIX/lib/*.la -rf

And then the users will think why use jhbuild run with the system command rm. The users will think 'I thought jhbuild run was for jhbuilt software'.

Thank you for the patch. Committed.

http://git.gnome.org/browse/jhbuild/commit/?id=f52ee06486cb61e9e05bc62995cff6e045927187
Comment 5 Colin Walters 2011-06-22 14:41:14 UTC
(In reply to comment #4)
>
> jhbuild run rm $JHBUILD_PREFIX/lib/*.la -rf
> 
> And then the users will think why use jhbuild run with the system command rm.

Ah, well I think I'd like to migrate to where the first thing we tell jhbuilders to do is:

jhbuild shell

And then work from inside there.  I understand why we weren't doing this before; it means all commands (e.g. ssh) get run under the jhbuild envrionment.  But gnome-terminal has tabs and new windows for that.

> The users will think 'I thought jhbuild run was for jhbuilt software'.
> 
> Thank you for the patch. Committed.
> 
> http://git.gnome.org/browse/jhbuild/commit/?id=f52ee06486cb61e9e05bc62995cff6e045927187

Thank you!