GNOME Bugzilla – Bug 652721
FolksIndividual should prefer the largest avatar available
Last modified: 2012-08-06 17:45:44 UTC
This should be good enough to consider their selection "stable" as well.
Punting bugs that won't be fixed by Folks 0.6.0.
(Setting target bugs for Folks 0.6.1. Search for this phrase to deal with bug mail spam.)
Didn't make this release; punting to 0.6.2.
I don't think this is right. If we always use the largest avatar then it might be impossible for an app such as contacts to set a different avatar, unless it happens to be larger that the largest avatar, or the largest avatar happens to have a writable avatar field. bug 657783 has more about this.
Agreed, it would be best to use the avatar from the primary store if possible, and rank avatars by size after that.
(Punting bugs to 0.6.4)
I can't actually see an easy way to get the sizes of avatars (which are GLoadableIcons) without loading them (probably from disk) and calling gdk-pixbuf methods on them to get their dimensions. Even if we removed the gdk-pixbuf dependency by hackily comparing the avatars by file size, this seems fairly heavyweight. If this is the only way to rank avatars by size, I think I'd prefer to not do it. If I'm missing a neat way to get their dimensions cheaply, please say so. (Note: We now prefer avatars from writeable stores over those which aren't, as per bug #657783.)
(mass bump to gnome-3.4 milestone in our new milestone scheme; search this string mass move bug mail)
Didn't make gnome-3.4 release, punting to gnome-3.6 milestone
Philip, Travis, Because we already prefer avatars from writable stores as you said in Comment 7, do we still need to do anything with this bug? or is it basically solved by that fix?
(In reply to comment #10) > Philip, Travis, > > Because we already prefer avatars from writable stores as you said in Comment > 7, do we still need to do anything with this bug? or is it basically solved by > that fix? We still don’t rank avatars by size after ranking by persona store. As in comment #7 though, I can’t think of a way to efficiently do this. So unless someone else can, I guess we can close this as fixed.
(In reply to comment #11) > (In reply to comment #10) > > Philip, Travis, > > > > Because we already prefer avatars from writable stores as you said in Comment > > 7, do we still need to do anything with this bug? or is it basically solved by > > that fix? > > We still don’t rank avatars by size after ranking by persona store. As in > comment #7 though, I can’t think of a way to efficiently do this. So unless > someone else can, I guess we can close this as fixed. Seems like a WONTFIX more than a FIXED. Please change if you disagree.