After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 652715 - theme: Make the running indicator look as it's supposed to
theme: Make the running indicator look as it's supposed to
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 649570 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-06-16 11:05 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2011-06-27 17:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
theme: Make the running indicator look as it's supposed to (4.57 KB, patch)
2011-06-16 11:05 UTC, Jasper St. Pierre (not reading bugmail)
reviewed Details | Review
theme: Make the running indicator look as it's supposed to (4.62 KB, patch)
2011-06-27 16:54 UTC, Jasper St. Pierre (not reading bugmail)
committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2011-06-16 11:05:18 UTC
Apparently, the running indicators were supposed to look as they do in the mockup:

http://git.gnome.org/browse/gnome-shell-design/plain/mockups/static/overview-window-picker.png

But for some random reason, the edges of the SVG were being clipped when using it
as a background-image on the dash, which made the effect rather subtle compared to
the correct behavior.

I'm attaching patch that modifies the SVG here so people can try the "correct" look,
but we should probably find the real cause of the clipping bug.
Comment 1 Jasper St. Pierre (not reading bugmail) 2011-06-16 11:05:21 UTC
Created attachment 190028 [details] [review]
theme: Make the running indicator look as it's supposed to

For some reason, the background-image clips the edges of the SVG. Rather
than spend valuable time diagnosing the real reason, hack around it by
pushing the edge elements of the SVG inward!
Comment 2 Dan Winship 2011-06-27 13:20:51 UTC
Comment on attachment 190028 [details] [review]
theme: Make the running indicator look as it's supposed to

>For some reason, the background-image clips the edges of the SVG. Rather
>than spend valuable time diagnosing the real reason, hack around it by
>pushing the edge elements of the SVG inward!

We intentionally clip the background image to the size of the actor. Thus, fixing the SVG is correct, and this patch is OK to commit with an updated commit message that doesn't imply that it's a hack.
Comment 3 Dan Winship 2011-06-27 14:34:50 UTC
*** Bug 649570 has been marked as a duplicate of this bug. ***
Comment 4 Jasper St. Pierre (not reading bugmail) 2011-06-27 16:54:07 UTC
Created attachment 190777 [details] [review]
theme: Make the running indicator look as it's supposed to

background-image is intentionally being clipped to an actor's size,
but the running indicator SVG source didn't take this into account.
So the running indicator didn't actually work properly, and was a
lot more subtle than intended.
Comment 5 Jasper St. Pierre (not reading bugmail) 2011-06-27 17:11:10 UTC
Attachment 190777 [details] pushed as ab0a5d4 - theme: Make the running indicator look as it's supposed to