GNOME Bugzilla – Bug 652670
Combine account parameter editing and personal information editing
Last modified: 2011-12-22 10:09:33 UTC
Created attachment 189993 [details] mockups Editing personal information should be moved into empathy-accounts. The current accounts parameters should be moved into an "Edit Account Parameters" button which shows the account parameters in a slideout -OR- launches GNOME Online Accounts (if CANNOT_SET_PARAMETERS is set). The main view should show the personal information you can edit: e.g. alias, avatar, vcard data.
WIP: http://cgit.collabora.com/git/user/danni/empathy.git/log/?h=combine-dialogs-652670
Let me know when this branch is ready for review.
*** Bug 599171 has been marked as a duplicate of this bug. ***
We are past UI freeze so that probably won't make it for 3.2.
So, I started cleaning up your branch: http://cgit.collabora.com/git/user/cassidy/empathy/log/?h=combine-dialogs-652670 The last big missing piece is creation of new account. This not covered by your mockup; are we going to move the protocol chooser to the account widget? I think that's the logical place to move it but may rise some questions: - I guess we should change the "Apply" button to a "Connect" one like we did in the accounts-dialog - What happen when hiting this button. Does the popup go away? If it does and the account fails to connect then user as to re-hit the "edit settings" button to bring it back. Or should we bring back the popup in this case? Then user may not see why the account fail to connect. Thoughts?
Thanks for finishing this off. This looks pretty good to me. Creation of new accounts includes #652669 -- which is sort of related. I wanted to make creation use the "simple" codepath. Because at the moment you only get the "simple" codepath is a very certain circumstance. Account creation should always be the same, no matter where you do it from. I think the popup goes away and it attempts to connect, then if it fails, you can click Edit and edit the settings and reclick Connect. I suppose the dialog could slide back out, but you might have multiple accounts failing to connect + it might be a network problem and you may just have to wait it out.
Here we go: http://cgit.collabora.com/git/user/cassidy/empathy/log/?h=combine-dialogs-652670 I still have to do some testing but it's basically done.
Looks good :)
Cool, the last remaining issues are cosmetic (the dialog looks a bit weird when switching from a widget displaying a lot of widgets to one displaying a single entry) so I merged it already. This branch already waited too much. :)