After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 652618 - themingengine: shrink the background size to the padding-box
themingengine: shrink the background size to the padding-box
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2011-06-15 05:11 UTC by Cosimo Cecchi
Modified: 2011-06-15 15:26 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
themingengine: shrink the background size to the padding-box (2.33 KB, patch)
2011-06-15 05:11 UTC, Cosimo Cecchi
committed Details | Review

Description Cosimo Cecchi 2011-06-15 05:11:42 UTC
The background needs to be shrunk to the padding-box for rounded corners to draw properly.
Comment 1 Cosimo Cecchi 2011-06-15 05:11:45 UTC
Created attachment 189957 [details] [review]
themingengine: shrink the background size to the padding-box

This fixes a regression introduced by this commit [1] that causes
background to draw beyond the padding-box, which breaks rounded corners,
(in addition to not being compliant with what CSS does by default).

[1] http://git.gnome.org/browse/gtk+/commit/?id=c56700ca3029a9ab1362009bff35f2a70e432c02
Comment 2 Cosimo Cecchi 2011-06-15 15:26:27 UTC
Fixed and pushed after a review from Benjamin on IRC.

Attachment 189957 [details] pushed as af77ba7 - themingengine: shrink the background size to the padding-box