After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 652545 - Remove G_CONST_RETURN usage, now that its gone in glib.
Remove G_CONST_RETURN usage, now that its gone in glib.
Status: RESOLVED FIXED
Product: libunique
Classification: Other
Component: core
master
Other All
: Normal normal
: ---
Assigned To: libunique-maint
libunique-maint
: 652479 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-06-14 11:39 UTC by Stef Walter
Modified: 2011-07-24 22:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Remove G_CONST_RETURN usage, now that its gone in glib. (5.84 KB, patch)
2011-06-14 11:39 UTC, Stef Walter
committed Details | Review
backport of patch to unique-1.1 branch (5.91 KB, patch)
2011-07-24 19:10 UTC, Alexandre Rostovtsev
accepted-commit_now Details | Review

Description Stef Walter 2011-06-14 11:39:49 UTC
This was removed in glib. Announced in gtk-devel-list
Comment 1 Stef Walter 2011-06-14 11:39:51 UTC
Created attachment 189891 [details] [review]
Remove G_CONST_RETURN usage, now that its gone in glib.
Comment 2 Emmanuele Bassi (:ebassi) 2011-06-14 12:33:11 UTC
thanks for the patch. pushed to master.
Comment 3 Emmanuele Bassi (:ebassi) 2011-06-14 12:33:36 UTC
*** Bug 652479 has been marked as a duplicate of this bug. ***
Comment 4 Alexandre Rostovtsev 2011-07-24 19:10:45 UTC
Created attachment 192571 [details] [review]
backport of patch to unique-1.1 branch

Please also fix G_CONST_RETURN in the unique-1.1 branch.

Stef Walter's patch didn't apply cleanly to unique-1.1, so I am attaching a backport of his patch.
Comment 5 Emmanuele Bassi (:ebassi) 2011-07-24 22:24:32 UTC
Review of attachment 192571 [details] [review]:

looks good, feel free to commit to the unique-1.1 branch.
Comment 6 Alexandre Rostovtsev 2011-07-24 22:31:35 UTC
(In reply to comment #5)
> Review of attachment 192571 [details] [review]:
> 
> looks good, feel free to commit to the unique-1.1 branch.

I don't have commit rights.