GNOME Bugzilla – Bug 652531
vinagre 3.1.2 - gcc warnings known to cause issues (raised to errors by Open Build Service)
Last modified: 2011-09-29 07:59:19 UTC
OBS reports those fatal errors: E: vinagre 64bit-portability-issue vinagre/vinagre-bookmarks-ui.c:46, 131 E: vinagre 64bit-portability-issue vinagre/vinagre-connect.c:404 E: vinagre 64bit-portability-issue vinagre/vinagre-prefs.c:216 E: vinagre 64bit-portability-issue vinagre/vinagre-reverse-vnc-listener-dialog.c:213 The respective compiler warnings are: 1) vinagre/vinagre-bookmarks-ui.c: In function 'show_dialog_folder': vinagre/vinagre-bookmarks-ui.c:46:3: warning: implicit declaration of function 'vinagre_utils_get_builder' [-Wimplicit-function-declaration] vinagre/vinagre-bookmarks-ui.c:46:7: warning: assignment makes pointer from integer without a cast [enabled by default] vinagre/vinagre-bookmarks-ui.c:77:4: warning: implicit declaration of function 'vinagre_utils_show_error_dialog' [-Wimplicit-function-declaration] vinagre/vinagre-bookmarks-ui.c: In function 'show_dialog_conn': vinagre/vinagre-bookmarks-ui.c:131:7: warning: assignment makes pointer from integer without a cast [enabled by default] 2) vinagre/vinagre-connect.c: In function 'vinagre_connect': vinagre/vinagre-connect.c:404:3: warning: implicit declaration of function 'vinagre_utils_get_builder' [-Wimplicit-function-declaration] vinagre/vinagre-connect.c:404:14: warning: assignment makes pointer from integer without a cast [enabled by default] vinagre/vinagre-connect.c:491:4: warning: implicit declaration of function 'vinagre_utils_show_error_dialog' [-Wimplicit-function-declaration] vinagre/vinagre-commands.c: In function 'vinagre_cmd_remote_open': vinagre/vinagre-commands.c:151:7: warning: implicit declaration of function 'vinagre_utils_show_error_dialog' [-Wimplicit-function-declaration] vinagre/vinagre-commands.c:186:7: warning: implicit declaration of function 'vinagre_utils_show_many_errors' [-Wimplicit-function-declaration] vinagre/vinagre-commands.c: In function 'vinagre_cmd_remote_vnc_listener': vinagre/vinagre-commands.c:224:5: warning: implicit declaration of function 'vinagre_reverse_vnc_listener_dialog_show' [-Wimplicit-function-declaration] vinagre/vinagre-commands.c: In function 'vinagre_cmd_help_contents': vinagre/vinagre-commands.c:344:3: warning: implicit declaration of function 'vinagre_utils_show_help' [-Wimplicit-function-declaration] vinagre/vinagre-commands.c: In function 'vinagre_cmd_help_about': vinagre/vinagre-commands.c:351:3: warning: implicit declaration of function 'vinagre_utils_show_help_about' [-Wimplicit-function-declaration] 3) vinagre/vinagre-notebook.c: In function 'tab_disconnected_cb': vinagre/vinagre-notebook.c:463:3: warning: implicit declaration of function 'vinagre_utils_show_error_dialog' [-Wimplicit-function-declaration] vinagre/vinagre-prefs.c: In function 'vinagre_prefs_dialog_response': vinagre/vinagre-prefs.c:198:7: warning: implicit declaration of function 'vinagre_utils_show_help' [-Wimplicit-function-declaration] vinagre/vinagre-prefs.c: In function 'vinagre_prefs_dialog_show': vinagre/vinagre-prefs.c:216:3: warning: implicit declaration of function 'vinagre_utils_get_builder' [-Wimplicit-function-declaration] vinagre/vinagre-prefs.c:216:15: warning: assignment makes pointer from integer without a cast [enabled by default] 4) vinagre/vinagre-reverse-vnc-listener-dialog.c: In function 'dialog_response_handler': vinagre/vinagre-reverse-vnc-listener-dialog.c:147:2: warning: implicit declaration of function 'vinagre_utils_show_help' [-Wimplicit-function-declaration] vinagre/vinagre-reverse-vnc-listener-dialog.c: In function 'vinagre_reverse_vnc_listener_dialog_show': vinagre/vinagre-reverse-vnc-listener-dialog.c:213:3: warning: implicit declaration of function 'vinagre_utils_get_builder' [-Wimplicit-function-declaration] vinagre/vinagre-reverse-vnc-listener-dialog.c:213:7: warning: assignment makes pointer from integer without a cast [enabled by default] => Indeed, those functions are not defined in any header file which would be included, thus resulting in undefined function prototypes.
Created attachment 190085 [details] [review] Generate a vinagre-utils.h header to fix warnings We need a vinagre-utils.h header for that. I've hacked the Makefile to make this happen, but I'm unsure my hacking is the best way to deal with that. I can't imagine another way, though...
Comment on attachment 190085 [details] [review] Generate a vinagre-utils.h header to fix warnings Urgh, not like that please! Marc-Andre has a much cleaner solution: https://gitorious.org/vinagre/vinagre-elmarco/commit/0d7727a501e2d9fcf911b9a96fda384e53878af5 However, this will be solved properly once the vala-rewrite branch is complete and merged, so feel free to use either solution for the OBS packages until then.
*** Bug 653565 has been marked as a duplicate of this bug. ***
*** Bug 660373 has been marked as a duplicate of this bug. ***