GNOME Bugzilla – Bug 652299
Don't show non-functional lock button
Last modified: 2011-06-10 15:38:30 UTC
My user has administrator rights, which means that by the default polkit policy I don't need further permission to make changes in the datetime panel. While the panel is correctly unlocked, it can not be locked - clicking the lock button does not have any effect (as the permission cannot be released). Luckily, it looks like an easy fix :-)
Created attachment 189648 [details] [review] shell: Don't update the visibility of the lock button Currently the lock button's visibility is updated on permission changes - if the active panel does provide a permission object, the button is shown, otherwise hidden. As GtkLockButton itself does manage its visibility, it is not necessary to handle it in g-c-c. In fact it is harmful, as the more sophisticated handling in GtkLockButton is overwritten: for instances, GtkLockButton hides itself if an action is allowed and the permission can not be released. By overwriting the behavior, gnome-control-center ends up showing a non-functional button.
Comment on attachment 189648 [details] [review] shell: Don't update the visibility of the lock button Looks good!
Attachment 189648 [details] pushed as 0402e73 - shell: Don't update the visibility of the lock button Thanks for the quick review!