GNOME Bugzilla – Bug 652079
Dragging a launcher/window from the dash/workspace switcher onto an already running window doesn't do anything
Last modified: 2011-06-13 20:30:08 UTC
1. Open Activities 2. Grab a launcher 3. Drag it onto the top of an already running window 4. The launcher returns to the dash and the application doesn't start I need to aim exactly at an empty place to launch the application or to move a window from another workspace to the current one. When I drag a window from an another workspace, it frees up some place, but it's not really predictable where it will do it.
Created attachment 189432 [details] [review] overview: Allow dropping icons on windows Currently the user has to find an empty spot in the workspace to be able to launcha new instance of an app using dnd. This is unnecessary hard, so just allow dropping on windows too.
Created attachment 189434 [details] [review] overview: Allow dropping icons on windows Currently the user has to find an empty spot in the workspace to be able to launcha new instance of an app using dnd. This is unnecessary hard, so just allow dropping on windows too. -- Fix cursor.
Review of attachment 189434 [details] [review]: ::: js/ui/workspace.js @@ +309,3 @@ + handleDragOver : function(source, actor, x, y, time) { + if (source instanceof AppDisplay.AppWellIcon) + return DND.DragMotionResult.COPY_DROP; Doing it this way means it doesn't work for, e.g., recent files dragged from the search results. It's better to use source.shellWorkspaceLaunch as the check. But then again, shouldn't we be consistent and also ignore the windows as drop targets when dropping a window from a different workspace (using bump on the edge scrolling)? So maybe we should just always delegate to the workspace and call its handleDragOver and acceptDrop for everything?
Created attachment 189841 [details] [review] overview: Allow dropping icons on windows Currently the user has to find an empty spot in the workspace to be able to launcha new instance of an app using dnd. This is unnecessary hard, so just allow dropping on windows too. -- *) Always delegate handleDragOver and acceptDrop to the workspace
Review of attachment 189841 [details] [review]: Good to commit except for one stray import ::: js/ui/workspace.js @@ +10,3 @@ const Signals = imports.signals; +const AppDisplay = imports.ui.appDisplay; You don't use this import
Attachment 189841 [details] pushed as 96dca48 - overview: Allow dropping icons on windows