After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 652045 - file open dialog refuses to open or complete non-local files
file open dialog refuses to open or complete non-local files
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkFileChooser
2.24.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
Federico Mena Quintero
: 652042 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-06-07 12:43 UTC by Michal 'hramrach' Suchanek
Modified: 2011-08-17 16:23 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch to enable entering URIs in file open dialog (583 bytes, patch)
2011-06-07 17:14 UTC, Michal 'hramrach' Suchanek
none Details | Review
bgo#652045 - Initialize local_only in GtkFileChooserEntry (962 bytes, patch)
2011-06-08 21:06 UTC, Federico Mena Quintero
committed Details | Review

Description Michal 'hramrach' Suchanek 2011-06-07 12:43:33 UTC
It is not possible to open or complete filename URIs in file open dialog.

Typing smb://server/share/dir<tab> results in a message that only local files are allowed although the file open button has the "local only" property set to false.
 
Setting the "local only" property to false allows loading remote URIs through bookmarks but typing them in the filechooser entry does not work.

In gtk 3 it is not even possible to type the URI.
Comment 1 Michal 'hramrach' Suchanek 2011-06-07 17:14:57 UTC
Created attachment 189419 [details] [review]
patch to enable entering URIs in file open dialog

This is because the location entry is not properly initialized.

Attaching a bandaid patch that initializes the local_only property which causes this issue in its default value.

However, I suggest implementing a gtk_file_chooser copy constructor and using it in all paces where a gtk_file_chooser subwidget is constructed,
Comment 2 Michal 'hramrach' Suchanek 2011-06-07 17:16:08 UTC
*** Bug 652042 has been marked as a duplicate of this bug. ***
Comment 3 Federico Mena Quintero 2011-06-08 21:05:43 UTC
Thank you for catching this!  I just pushed this to master and gtk-3-0.
Comment 4 Federico Mena Quintero 2011-06-08 21:06:08 UTC
Created attachment 189505 [details] [review]
bgo#652045 - Initialize local_only in GtkFileChooserEntry

This has to be done also when we switch to the entry, otherwise completion for
non-local URIs won't work.
Comment 5 Michal 'hramrach' Suchanek 2011-08-17 14:50:01 UTC
Only the latter patch is present in 2.24.5
Comment 6 Michal 'hramrach' Suchanek 2011-08-17 15:01:22 UTC
oh, it's not present, it's the same patch both, only the line number has changed.
Comment 7 Federico Mena Quintero 2011-08-17 16:02:09 UTC
Oops, sorry, I forgot to push it to gtk-2-24 as well.  It's pushed now.
Comment 8 Michal 'hramrach' Suchanek 2011-08-17 16:23:47 UTC
thanks