After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 651931 - Add "Add Bookmark" to the sidepane context menu
Add "Add Bookmark" to the sidepane context menu
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: [obsolete] Sidebar
unspecified
Other All
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-06-05 14:07 UTC by Paolo Borelli
Modified: 2011-06-15 15:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add "Add Bookmark" to the sidepane context menu (3.35 KB, patch)
2011-06-05 14:07 UTC, Paolo Borelli 		reviewed Details | Review

Description Paolo Borelli 2011-06-05 14:07:29 UTC 
Add an "Add Bookmark" menu item to the items in the sidepane that can be bookmarked.
Comment 1 Paolo Borelli 2011-06-05 14:07:32 UTC 
Created attachment 189267 [details] [review]
Add "Add Bookmark" to the sidepane context menu
Comment 2 Cosimo Cecchi 2011-06-06 21:46:58 UTC 
Review of attachment 189267 [details] [review]:

Thanks for the patch!
I like the fact that you hide the context item for rows which are not volumes; I think it should also be hidden in the case when a bookmark for the mount is already present (or is this somehow done implicitly?).
Comment 3 Paolo Borelli 2011-06-07 07:21:57 UTC 
I do not think it should be hidden in that case: it should be made insensitive. HIG says that available actions should always be present so that a user can learn about them, but be grayed out if not applicable in this particular state.

That said, I did not do that (yet) because also the main menu "Add bookmark" sensitivity is not managed in any way, so I kept it consistent (it would be weird that the same action is grayed out when accessing it one way, but available from another).

I think the sensitivity should be addressed in a second changeset for both places.
Comment 4 Paolo Borelli 2011-06-15 15:03:41 UTC 
I pushed the patch and filed https://bugzilla.gnome.org/show_bug.cgi?id=652656 for the sensitivity