After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 651807 - Fix GTKNewsFeedLoader for versions of PHP which do not support json_decode
Fix GTKNewsFeedLoader for versions of PHP which do not support json_decode
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Website
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
Martyn Russell
Depends on:
Blocks:
 
 
Reported: 2011-06-03 19:34 UTC by Devin Samarin
Modified: 2011-06-06 09:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to fix said problems (41.87 KB, patch)
2011-06-03 19:34 UTC, Devin Samarin 		none Details | Review

Description Devin Samarin 2011-06-03 19:34:21 UTC 
Created attachment 189178 [details] [review]
Patch to fix said problems

Please read this carefully :) Technical discussion sucks.

Here is a patch to fix the json_decode function for the GTK+ website. This should be treated as a *temporary* solution to the problem, as this function is enormously slow. Because of this, caching is recommended (or upgrading). To enable caching, make sure the correct write permissions are available for libs/newsfeed.cache.txt. This is the main file which is updated every once-in-a-while (1 hour by default).

Once the version of PHP is upgraded to one that supports the native json_decode function, the native version will be used instead.

This patch also removes code that was once used during website development which is no longer needed.

I hope I haven't missed anything.
Comment 1 Martyn Russell 2011-06-06 09:50:46 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.

Thanks for the patch Devin