GNOME Bugzilla – Bug 651586
Auto Move Windows: overview is not shown when closing last window
Last modified: 2011-07-09 14:01:01 UTC
Created attachment 188958 [details] [review] Patch to open overview when closing the last window on a workspace Using the auto move windows extension the overview is not shown when the last window on a workspace is closed. Instead, a workspace switch to the previous workspace is triggered. A patch, that basicaly merges from gnome-shell master, is attached that seems to fix the issue for me
Created attachment 189017 [details] [review] [Patch] open overview when last window is closed Open overview also when the window closed is on the last workspace
Review of attachment 189017 [details] [review]: I don't know that code very well, but you're the original author, so I'm confident you know what you do, and anyway bugs will be surely reported before 3.2.
Well this mimic the standard Gnome Shell experience where the overview is shown upon closing the last window on a workspace. It has some shortcomings with the auto move window extension that I couldn't really address: Take for example a situation where I have Evo on workspace two and I open Rhythmbox, that is scheduled for moving on workspace three. That means that Rhythmbox is opened on workspace one and moved to three. This is seen emptying workspace one, hence the overview is shown, which might be unwanted. Summarizing: Before patch - I am on the last workspace and I close its last window -> workspace changes to the previous non empty one, no overview is shown This patch - I am on a workspace (no matter which one) and I close its last window -> Overview is shown, no workspace change occurs - This has glitches due to the automoving (see example at the beginning) After writing this I realized that there might be a different solution: change the code to open the overview only when using the last workspace. That means: Possible different solution - I am on workspace one (or any workspace but the last) and I close its last window -> nothing happens (no overview shown, no workspace change) - I am on the last workspace and I close its last window -> overview is shown Which one would you prefer?
(In reply to comment #3) > [...] > > Which one would you prefer? Sorry for late answer. Anyway, among the three (old, patch, proposal), I prefer the last one, that is, use gnome-shell-core behavior when on the last workspace, and keep showing the workspace everywhere else. This way one can have a set of fixed, allocated workspaces (with apps assigned to them), and still add dynamic workspaces at the end, with functionality similar to core shell.
Created attachment 191220 [details] [review] Patch to open overview when closing the last window on the last workspace I prefer to adhere to the core Gnome Shell as well and show the overview only when the last window of the last workspace is closed. This patch should achieve that behaviour. This also avoids glitches introduced by the previous patch when automoving windows between empty spaces (see previous comments)
Thanks a lot, Alessandro! This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.