GNOME Bugzilla – Bug 651327
Minor fixes for the gsocket API
Last modified: 2011-05-28 23:47:21 UTC
Here's a couple of minor fixes for error reporting in the GSocket API.
Created attachment 188807 [details] [review] gsocket: Fix the error message for a failed g_socket_shutdown The GError message for g_socket_shutdown was reporting that it was "Unable to create socket" which is presumably a cut-and-paste bug.
Created attachment 188808 [details] [review] gsocket: Fix some cases of returning error without setting *error g_socket_shutdown and g_socket_close were calling check_socket with a NULL error parameter so any errors wouldn't get propagated up.
Review of attachment 188807 [details] [review]: looks good
Review of attachment 188808 [details] [review]: seems obviously correct to me, but danw or davidz might want to look at it as well.
Review of attachment 188807 [details] [review]: Good catch
The following fixes have been pushed: 2df4750 gsocket: Fix some cases of returning error without setting *error 0703dbc gsocket: Fix the error message for a failed g_socket_shutdown
Created attachment 188820 [details] [review] gsocket: Fix some cases of returning error without setting *error g_socket_shutdown and g_socket_close were calling check_socket with a NULL error parameter so any errors wouldn't get propagated up.
Created attachment 188821 [details] [review] gsocket: Fix the error message for a failed g_socket_shutdown The GError message for g_socket_shutdown was reporting that it was "Unable to create socket" which is presumably a cut-and-paste bug.