After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 651223 - Fix some compile warnings on OpenBSD
Fix some compile warnings on OpenBSD
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
2.28.x
Other OpenBSD
: Normal minor
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2011-05-27 09:12 UTC by Antoine Jacoutot
Modified: 2011-05-28 23:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
move arpa headers down the list as they depend on other headers (1007 bytes, patch)
2011-05-27 09:12 UTC, Antoine Jacoutot 		committed Details | Review
Fix compile warnings on OpenBSD. (1.03 KB, patch)
2011-05-28 23:01 UTC, Matthias Clasen 		committed Details | Review

Description Antoine Jacoutot 2011-05-27 09:12:27 UTC 
Created attachment 188733 [details] [review]
move arpa headers down the list as they depend on other headers

Hi.

Some headers reshuffling is needed on OpenBSD to prevent the following warnings.
I doubt this have any "bad" side effect on other platforms.

/usr/include/arpa/inet.h:74: warning: 'struct in_addr' declared inside parameter list
/usr/include/arpa/inet.h:74: warning: its scope is only this definition or declaration, which is probably not what you want
/usr/include/arpa/inet.h:75: warning: 'struct in_addr' declared inside parameter list

Thoughts?
Comment 1 Dan Winship 2011-05-27 12:45:22 UTC 
(In reply to comment #0)
> Thoughts?

Yes. Fix OpenBSD. Headers-that-have-to-be-included-in-a-certain-order are so 20th century.
Comment 2 Antoine Jacoutot 2011-05-27 12:56:16 UTC 
(In reply to comment #1)
> (In reply to comment #0)
> > Thoughts?
> 
> Yes. Fix OpenBSD. Headers-that-have-to-be-included-in-a-certain-order are so
> 20th century.

Yeah yeah, I don't make all the rules and as long as it makes _everyone_ happy, who cares ;-)
Comment 3 Matthias Clasen 2011-05-28 23:01:44 UTC 
Annoying indeed.
But since it doesn't hurt, I've committed it as
56c0d0f Fix compile warnings on OpenBSD.
Comment 4 Matthias Clasen 2011-05-28 23:01:55 UTC 
Created attachment 188819 [details] [review]
Fix compile warnings on OpenBSD.