After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 651115 - CheeseAvatarChooser looks weird
CheeseAvatarChooser looks weird
Status: RESOLVED OBSOLETE
Product: cheese
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: 2.32
Assigned To: Cheese Maintainer(s)
Cheese Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2011-05-26 07:24 UTC by Guillaume Desmottes
Modified: 2013-11-12 16:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
libcheese: take_a_photo button aligned to center (1.30 KB, patch)
2011-06-07 20:01 UTC, Raluca-Elena Podiuc
committed Details | Review
screenshot for the alignement (251.32 KB, image/png)
2011-06-07 20:03 UTC, Raluca-Elena Podiuc
  Details

Description Guillaume Desmottes 2011-05-26 07:24:39 UTC
See http://swarm.cs.pub.ro/~raluca/empathy/Empathy-Take-a-photo-dialog.png

The position of the Take/Discard photo looks weird, put it in the middle?
Also, shouldn't we add some padding?
Comment 1 Raluca-Elena Podiuc 2011-06-07 20:01:54 UTC
Created attachment 189428 [details] [review]
libcheese: take_a_photo button aligned to center
Comment 2 Raluca-Elena Podiuc 2011-06-07 20:03:12 UTC
Created attachment 189429 [details]
screenshot for the alignement
Comment 3 Luciana Fujii 2011-06-24 03:26:48 UTC
Review of attachment 189428 [details] [review]:

Pushed as 98d4c4970fd664110dc4ecec0e0438f979c58d4f
Comment 4 Luciana Fujii 2011-06-24 03:30:39 UTC
Thanks for the patch. Changing the alignment of the button was certainly an improvement.

Guillaume, do you have a suggestion for padding?
Comment 5 Guillaume Desmottes 2011-06-24 07:05:47 UTC
Not sure, the dialog looks a bit weird to me but I'm not sure why exactly.
Maybe ask the UX team for some input?
Comment 6 David King 2013-11-12 16:31:56 UTC
This now looks a lot better, with the great work that Bastien did on the avatar chooser in bug 710874.