After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 651061 - Upgrades to javascript lang
Upgrades to javascript lang
Status: RESOLVED FIXED
Product: gtksourceview
Classification: Platform
Component: Syntax files
git master
Other All
: Normal enhancement
: ---
Assigned To: GTK Sourceview maintainers
GTK Sourceview maintainers
Depends on:
Blocks:
 
 
Reported: 2011-05-25 13:22 UTC by Carnë Draug
Modified: 2011-05-26 14:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
01 - ref comment to def (2.49 KB, patch)
2011-05-25 13:23 UTC, Carnë Draug 		committed Details | Review
02 - fixed indentation for 2 spaces (24.79 KB, patch)
2011-05-25 13:25 UTC, Carnë Draug 		committed Details | Review
3 - ref strings to def (2.03 KB, patch)
2011-05-25 13:27 UTC, Carnë Draug 		committed Details | Review
4 - main context to bottom (17.39 KB, patch)
2011-05-25 13:28 UTC, Carnë Draug 		none Details | Review
04 - main context to bottom (17.39 KB, patch)
2011-05-25 13:35 UTC, Carnë Draug 		committed Details | Review
05 - changes requested by ##javascript on freenode (4.20 KB, patch)
2011-05-25 13:38 UTC, Carnë Draug 		committed Details | Review

Description Carnë Draug 2011-05-25 13:22:06 UTC 
Hi

I made a bunch of upgrades to javascript.lang. There's 5 commits total. I used the "check_language.sh" script and it says that the file validates.
Comment 1 Carnë Draug 2011-05-25 13:23:32 UTC 
Created attachment 188589 [details] [review]
01 - ref comment to def

ref comment and error on comments contexts to def and removed respective styles
Comment 2 Carnë Draug 2011-05-25 13:25:11 UTC 
Created attachment 188591 [details] [review]
02 - fixed indentation for 2 spaces

Moved contexts definitions out of main context
Comment 3 Carnë Draug 2011-05-25 13:26:25 UTC 
Comment on attachment 188591 [details] [review]
02 - fixed indentation for 2 spaces

fixed indentation for 2 spaces
Comment 4 Carnë Draug 2011-05-25 13:27:15 UTC 
Created attachment 188592 [details] [review]
3 - ref strings to def

ref string contexts to def and removed respective styles
Comment 5 Carnë Draug 2011-05-25 13:28:00 UTC 
Created attachment 188593 [details] [review]
4 - main context to bottom

Moved contexts definitions out of main context
Comment 6 Carnë Draug 2011-05-25 13:35:31 UTC 
Created attachment 188594 [details] [review]
04 - main context to bottom

Moved contexts definitions out of main context
Comment 7 Carnë Draug 2011-05-25 13:38:24 UTC 
Created attachment 188595 [details] [review]
05 - changes requested by ##javascript on freenode

Under direction of people on ##javascript
  * added prefix \. to properties
  * moved Math to constructors
  * moved null to types
  * moved POSITIVE/NEGATIVE_INFINITY to properties
  * added note on how to highlight undefined properly
  * moved objects context keywords into properties
  * removed no longer necessary styles
  * changed functions style ref to def:builtin
Comment 8 Ignacio Casal Quinteiro (nacho) 2011-05-25 14:44:14 UTC 
Review of attachment 188595 [details] [review]:

Let's go for it.
Comment 9 Ignacio Casal Quinteiro (nacho) 2011-05-26 14:23:20 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.