After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 65101 - sheet names not quoted
sheet names not quoted
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2001-11-22 06:43 UTC by Andreas J. Guelzow
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Andreas J. Guelzow 2001-11-22 06:43:46 UTC
This problem is similar tot eh two-byte japanes sheet name problem
discussed on the gnumeric list:

Rename a sheet to "A,1"
choose Correlation Analysis tool
select a range on the sheet A,1
since the sheet name is not quoted the okay button doesn't become active.

reason:

	static char quote_chr [] =
	{ '=', '<', '>', '(', ')', '+', '-', ' ', '^', '&', '%', ':', '/',
	  '*', '\\', '`', '\'', '´', '\0'};

doesn't include ','

Solution:

we should rewrite sheet_name_quote such that all characters but
alphanumerics cause quoting. (This may also solve the japanese two-byte
problem)
Comment 1 Jody Goldberg 2001-11-22 07:17:35 UTC
Good idea.  This also demonstrated a bug in the original routine.
I'll commit the patch shortly.
Comment 2 Andreas J. Guelzow 2001-11-22 15:12:03 UTC
You may or may not have noticed that your patch doesn't fix the
described situation. It did fix the similar situation for the t-test
tool  or any situation expecting a single range. There is another bug
  in the global_range_list_parse code: it doesn't differentiate
between commas in sheet names and elsewhere.  

I have fixed that bug and will be sending you a diff shortly.