GNOME Bugzilla – Bug 650914
decklink sink has no audio support
Last modified: 2011-06-29 14:48:56 UTC
Created attachment 188423 [details] [review] initial audio support for decklink cards The audio pad of the decklink sink is not yet implemented. I'd like to discuss here it's implementation as I write it. Attached is an initial patch that includes audio support, but does not take care yet of synchronization.
I'll post here two approaches I'm writing.
Created attachment 188662 [details] [review] approach 1 (this one I get a fair sync when audio is present) no audio, no playback
Comment on attachment 188662 [details] [review] approach 1 (this one I get a fair sync when audio is present) no audio, no playback This one make A/V in sync is video PTS is ahead of audio PTS inside the TS (which is always the case of a BTS, AFAIK). But do not cover all file cases.
Created attachment 188663 [details] [review] approach 2 (this one does not really implements sync, but an other way to write the audio samples)
As I have 2 blackmagic cards in my machine and I wanted to use the second one, I setted: int card_number = 1; Please set this to 0 if you have only one card.
commit bb4844b29eaf3551d32d95835ce77bf326687fbb Author: Rafael Diniz <rafael@riseup.net> Date: Sun Jun 5 21:19:58 2011 -0700 decklinksink: Add audio support Signed-off-by: David Schleef <ds@schleef.org>
The applied patch does not respect any PTS or timing at all. Should I open a new bug with a name like: "Decklink sink does not respect PTS" ?
> Should I open a new bug with a name like: > "Decklink sink does not respect PTS" Yes, please!