After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 650675 - clutter-media: mention the asynchronous behavior of set_playing()
clutter-media: mention the asynchronous behavior of set_playing()
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: Documentation
1.6
Other Linux
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks:
 
 
Reported: 2011-05-20 14:31 UTC by sdegrande
Modified: 2011-07-04 15:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (1.20 KB, patch)
2011-05-20 14:31 UTC, sdegrande 		committed Details | Review

Description sdegrande 2011-05-20 14:31:03 UTC 
Created attachment 188224 [details] [review]
Proposed patch

Depending on the ClutterMedia implementation, the set_playing()
call can be asynchronous, the playing state's change being not
immediate.

This is related to http://bugzilla.clutter-project.org/show_bug.cgi?id=2654
Comment 1 Emmanuele Bassi (:ebassi) 2011-05-25 10:14:38 UTC 
Review of attachment 188224 [details] [review]:

it generally looks okay to me, aside from a couple of remarks that should be fixed prior to commit.

::: clutter/clutter-media.c
@@ +285,3 @@
+ * The implementation might be asynchronous, so the way to know 
+ * the actual playing state of the @media is to use the #GObject::notify
+ * signal on the ::playing property and then retrieve the current state with

the link should be #ClutterMedia:playing

@@ +288,3 @@
+ * clutter_media_get_playing().
+ *
+ * (ClutterGstVideoTexture is an example of such an asynchronous implementation)

don't use the parenthesis: it's fine as a remark on the previous paragraph.
Comment 2 Emmanuele Bassi (:ebassi) 2011-07-04 14:59:09 UTC 
I've pushed attachment 188224 [details] [review] after modifying it. thanks for the patch.
Comment 3 sdegrande 2011-07-04 15:30:13 UTC 
Oops, I forgot to fix the patch. Sorry...