GNOME Bugzilla – Bug 650562
"review required" is a dead end
Last modified: 2013-01-21 13:47:57 UTC
I may have missed the point of "review required", however It seems that once a document is set to "review required" then, - a reviewer cannot "reserve for review" - a translator cannot "undo last state" To get out you can do 1. reserve for translation 2. upload new translation which forces to upload a file See for example the workflow at: (frenglish) http://l10n.gnome.org/vertimus/gnome-devel-docs/master/platform-overview/fr
Note: I think I now understood what "review required" is meant to be. "review required" is not a flag for the translator to require review from peers. But - A uploads a document which becomes "translated", - B finds errors in the document, B set "review required" to notify A that the document need to be reworked right?
Yes and when no errors are found by the reviewer, the translation when be flagged `Ready for submission'.
I re-open this one, as I noticed another translator just did the same mistake that I did: once translated, to mark the document as "review required" to request a review. There is clearly a bug, either - the label is misleading - the state machine is wrong / too restrictive - the user doc is not clear or not available - other As an example, Bugzilla links the "status" to a page documenting the state machine (from UNCONFIRMED to CLOSED). Maybe DL could have a short summary of Actions right next to the button. I was also suggesting a different UI for action selection (bug #650571)
About the label, what about "To be redone" or "To be retranslated"? As a first measure, I will remove this option for 'simple' translators.
(In reply to comment #4) > About the label, what about "To be redone" or "To be retranslated"? I feel it's a bit harsh toward the translator. What about "rework needed"? Overall I think that the state machine (the work-flow) should be - reviewed - documented (right there where it is used) - made more general and less restrictive (?) My personal feeling is that currently it is a bit awkward. After a few months of use I still don't really get it, although it should be pretty simple and straight forward.
(In reply to comment #5) > I feel it's a bit harsh toward the translator. What about "rework needed"? Current wording can also have a bad reception by the original translator. As a reviewer, I once used it the way it's meant to be used (I reviewed the file and I had comments about what needed to be fixed) and a heated discussion followed in which the translator told me he didn't need to be schooled and that if I were not happy with his work I might just as well do it myself. See the thread about Ease translation (in French) at http://listes.traduc.org/pipermail/gnomefr/2011-June/thread.html > - reviewed > - documented (right there where it is used) > - made more general and less restrictive (?) I'd be happy to help with all of that.
Alexandre, are you OK with "Rework needed"? Should we ask an English native speaker? There is a documentation of the state machine in http://git.gnome.org/browse/damned-lies/plain/docs/vertimus-workflow.svg. We could link it from the Web site. Where should it be the most appropriate?
(In reply to comment #6) > > - reviewed > > - documented (right there where it is used) > > - made more general and less restrictive (?) > > I'd be happy to help with all of that. Go ahead!
(In reply to comment #7) > Alexandre, are you OK with "Rework needed"? Should we ask an English native > speaker? I agree with myself (if it helps to go forward) A minimal alternative is to change the French translation. > > There is a documentation of the state machine in > http://git.gnome.org/browse/damned-lies/plain/docs/vertimus-workflow.svg. Nice! (I understand better why I had difficulties to picture it mentally :) > We > could link it from the Web site. Where should it be the most appropriate? This would be a great start! What about next to the "Action" drop down list?
(In reply to comment #9) > A minimal alternative is to change the French translation. Bruno proposes: "Traduction à améliorer" http://listes.traduc.org/pipermail/gnomefr/2011-August/006418.html
Summary of what I've done so far: - Remove "review required" action for translators - Renamed "Review required" -> "Rework needed" - Added help link on vertimus page to show the state machine documentation Could we consider this bug as fixed?
(In reply to comment #11) > Summary of what I've done so far: > - Remove "review required" action for translators > - Renamed "Review required" -> "Rework needed" > - Added help link on vertimus page to show the state machine documentation I would place it right next to the action choice, rather than at the end of the log : New Action ---------------------------------------------- Action: [ Reserve or translation |v] ((?)) <---- HERE > > Could we consider this bug as fixed? Yes! that's great, Thank You!
Done, thanks for your help to improve D-L.