After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 650554 - Make EmpathyTpChat a subclass of TpTextChannel
Make EmpathyTpChat a subclass of TpTextChannel
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Chat
2.33.x
Other Linux
: Normal enhancement
: 3.2
Assigned To: empathy-maint
Depends on:
Blocks:
 
 
Reported: 2011-05-19 08:52 UTC by Guillaume Desmottes
Modified: 2011-05-25 08:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
http://cgit.collabora.com/git/user/cassidy/empathy/log/?h=tp-chat-inherit-650554 (86.59 KB, patch)
2011-05-19 12:16 UTC, Guillaume Desmottes
none Details | Review

Description Guillaume Desmottes 2011-05-19 08:52:01 UTC
Now that we can define our own proxy features, EmpathyTpChat could become a TpTextChannel subclass.
Comment 1 Guillaume Desmottes 2011-05-19 12:16:25 UTC
Created attachment 188107 [details] [review]
http://cgit.collabora.com/git/user/cassidy/empathy/log/?h=tp-chat-inherit-650554

 libempathy-gtk/empathy-chat.c               |   81 ++-
 libempathy-gtk/empathy-contact-list-store.c |    9 +-
 libempathy/empathy-channel-factory.c        |   30 +-
 libempathy/empathy-chatroom-manager.c       |   43 +-
 libempathy/empathy-tp-chat.c                | 1000 ++++++++++++---------------
 libempathy/empathy-tp-chat.h                |   21 +-
 src/empathy-chat-manager.c                  |   90 +--
 src/empathy-chat-window.c                   |    2 +-
 src/empathy-event-manager.c                 |   24 +-
 src/empathy-invite-participant-dialog.c     |    7 +-
 10 files changed, 599 insertions(+), 708 deletions(-)
Comment 3 Guillaume Desmottes 2011-05-25 08:03:40 UTC
Reviewed by Danielle on IRC; merged to master.

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.