GNOME Bugzilla – Bug 650554
Make EmpathyTpChat a subclass of TpTextChannel
Last modified: 2011-05-25 08:03:40 UTC
Now that we can define our own proxy features, EmpathyTpChat could become a TpTextChannel subclass.
Created attachment 188107 [details] [review] http://cgit.collabora.com/git/user/cassidy/empathy/log/?h=tp-chat-inherit-650554 libempathy-gtk/empathy-chat.c | 81 ++- libempathy-gtk/empathy-contact-list-store.c | 9 +- libempathy/empathy-channel-factory.c | 30 +- libempathy/empathy-chatroom-manager.c | 43 +- libempathy/empathy-tp-chat.c | 1000 ++++++++++++--------------- libempathy/empathy-tp-chat.h | 21 +- src/empathy-chat-manager.c | 90 +-- src/empathy-chat-window.c | 2 +- src/empathy-event-manager.c | 24 +- src/empathy-invite-participant-dialog.c | 7 +- 10 files changed, 599 insertions(+), 708 deletions(-)
Best reviewing patch by patch. I opened a bunch of tp-glib bug regarding missing high levelAPI: https://bugs.freedesktop.org/buglist.cgi?status_whiteboard_type=allwordssubstr&query_format=advanced&status_whiteboard=EmpathyTpChat&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&component=tp-glib&product=Telepathy
Reviewed by Danielle on IRC; merged to master. This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.