Created attachment 188026 [details] [review]
Sync allocation in ClutterBoxLayout with the one in GtkBox

Created attachment 188098 [details] [review]
Sync allocation in ClutterBoxLayout with the one in GtkBox

Fixes issue that wasn't visible in the tests because all items have the same size

Created attachment 188102 [details] [review]
Sync allocation in ClutterBoxLayout with the one in GtkBox

Restores the animations

Created attachment 188103 [details] [review]
Sync allocation in ClutterBoxLayout with the one in GtkBox

Don't overwrite the initial allocation

Review of attachment 188103 [details] [review]:

::: clutter/clutter-box-layout.c
@@ +651,3 @@
+    box_child->x_fill,
+    box_child->y_fill,
+    flags);

this does not conform to the coding style; align to the first argument.

@@ +756,3 @@
+  *visible_children = *expand_children = 0;
+
+{

you're leaking the list of children here

@@ +880,3 @@
+      gint glue = (extra_space + i) / (i + 1);
+      gint gap = sizes[(spreading[i])].natural_size
+/*

should align the '-' to the '=' on the line above.

@@ +933,2 @@
+  /* Retrieve desired size for visible children. */
+  for (i = 0, children = clutter_container_get_children (container);

leaking the children list here as well.

@@ +1069,3 @@
+          child_size = sizes[i].minimum_size;
+
+        }

should probably use a ClutterBoxChild* variable at the beginning of the for block, to avoid multiple casting.

Created attachment 188555 [details] [review]
Sync allocation in ClutterBoxLayout with the one in GtkBox

Addresses issues mentioned in the review.

Attachment 188555 [details] pushed as e636a0b - Sync allocation in ClutterBoxLayout with the one in GtkBox

I did a minor edit, removing an unused variable to avoid the corresponding compiler warning.