After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 650440 - disable notifications by default
disable notifications by default
Status: RESOLVED FIXED
Product: jhbuild
Classification: Infrastructure
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on:
Blocks:
 
 
Reported: 2011-05-17 22:02 UTC by Colin Walters
Modified: 2011-05-19 06:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
disable notifications by default (1.60 KB, patch)
2011-05-17 22:02 UTC, Colin Walters
committed Details | Review

Description Colin Walters 2011-05-17 22:02:40 UTC
In GNOME 2 while it was a cute hack, I personally never found it useful.  No
other terminal apps use libnotify, and in GNOME 3 it's worse because
we persist notifications.  Basically if you're not an app, it's just
broken to use notifications.
Comment 1 Colin Walters 2011-05-17 22:02:42 UTC
Created attachment 187996 [details] [review]
disable notifications by default
Comment 2 Craig Keogh 2011-05-18 03:34:01 UTC
Comment on attachment 187996 [details] [review]
disable notifications by default

Thank you for the report and patch. Committed. I shorted your source code comment, I hope you don't mind.

http://git.gnome.org/browse/jhbuild/commit/?id=45ab65c9fb244d32b83c927b90bca33fadde0651
Comment 3 Dirk Wallenstein 2011-05-18 07:16:50 UTC
(In reply to comment #0)
> In GNOME 2 while it was a cute hack, I personally never found it useful.  No
> other terminal apps use libnotify, and in GNOME 3 it's worse because
> we persist notifications.  Basically if you're not an app, it's just
> broken to use notifications.

You start a build that will probably take over an hour and don't want to be informed if it hangs in a core component after a few minutes?
Comment 4 Craig Keogh 2011-05-18 08:15:58 UTC
(In reply to comment #3)

> You start a build that will probably take over an hour and don't want to be
> informed if it hangs in a core component after a few minutes?

Turn notifications on in your ~/.jhbuildrc. I agree with Colin, the default should be off to be consistent with terminal apps.
Comment 5 Craig Keogh 2011-05-18 08:26:11 UTC
I updated the documentation.
http://git.gnome.org/browse/jhbuild/commit/?id=993ac955873498bd8ade7a7d6e2918fa6216faa1

BTW, nonotify & notrayicon are terrible names for config variables. Double negative. I might open another bug for that.
Comment 6 Colin Walters 2011-05-18 19:57:02 UTC
(In reply to comment #3)
> (In reply to comment #0)
> > In GNOME 2 while it was a cute hack, I personally never found it useful.  No
> > other terminal apps use libnotify, and in GNOME 3 it's worse because
> > we persist notifications.  Basically if you're not an app, it's just
> > broken to use notifications.
> 
> You start a build that will probably take over an hour and don't want to be
> informed if it hangs in a core component after a few minutes?

Hangs...why?  Broken networking?
Comment 7 Dirk Wallenstein 2011-05-19 06:37:26 UTC
(In reply to comment #6)
> (In reply to comment #3)
> > (In reply to comment #0)
> > > In GNOME 2 while it was a cute hack, I personally never found it useful.  No
> > > other terminal apps use libnotify, and in GNOME 3 it's worse because
> > > we persist notifications.  Basically if you're not an app, it's just
> > > broken to use notifications.
> > 
> > You start a build that will probably take over an hour and don't want to be
> > informed if it hangs in a core component after a few minutes?
> 
> Hangs...why?  Broken networking?

Yeah (indeed my router has hiccups), or forgot to clear -Werror.  Whatever can happen during a build.  I just think it is a very helpful feature, and don't really get the concerns.  But, well, it can be turned on.   Or was it mostly getting in the way when acting on a single module (buildone)?