Bug 650420 – all: avoid boxed structs copying where possible

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 650420 - all: avoid boxed structs copying where possible


Summary:	all: avoid boxed structs copying where possible


Status:	RESOLVED FIXED

Product:	gtk+
Classification:	Platform
Component:	.General
Version:	unspecified
Hardware:	Other All

Importance:	Normal normal
Target Milestone:	---
Assigned To:	gtk-bugs
QA Contact:	gtk-bugs

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2011-05-17 18:23 UTC by Cosimo Cecchi
Modified:	2011-05-18 14:27 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
all: avoid boxed structs copying where possible (10.54 KB, patch) 2011-05-17 18:23 UTC, Cosimo Cecchi	committed	Details \| Review

Description Cosimo Cecchi 2011-05-17 18:23:42 UTC

We should use the GtkStyleContext accessors where possible, to avoid useless copies of those boxed structs.

Comment 1 Cosimo Cecchi 2011-05-17 18:23:45 UTC

Created attachment 187980 [details] [review]
all: avoid boxed structs copying where possible

Use the GtkStyleContext accessors for boxed properties where possible,
to reduce allocations.

Comment 2 Matthias Clasen 2011-05-18 13:58:17 UTC

Review of attachment 187980 [details] [review]:

No objections, looks better too.

Comment 3 Cosimo Cecchi 2011-05-18 14:27:53 UTC

Thanks, pushed to master.

Attachment 187980 [details] pushed as c8a59a6 - all: avoid boxed structs copying where possible