After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 650270 - Some CSS correctness fixes
Some CSS correctness fixes
Status: RESOLVED FIXED
Product: gnome-themes-standard
Classification: Core
Component: Adwaita GTK3 theme
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-themes-standard-maint
gnome-themes-standard-maint
Depends on:
Blocks:
 
 
Reported: 2011-05-16 00:53 UTC by Benjamin Otte (Company)
Modified: 2011-05-23 14:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
toolbars: Remove broken property (822 bytes, patch)
2011-05-16 00:54 UTC, Benjamin Otte (Company) 		none Details | Review
toolbars: Properly seperate toolbar classes from toolbutton classes (4.82 KB, patch)
2011-05-16 00:54 UTC, Benjamin Otte (Company) 		none Details | Review
menus: Split menu classes from menuitem classes (1.22 KB, patch)
2011-05-16 00:54 UTC, Benjamin Otte (Company) 		none Details | Review
menus: Make sure all menu children use the menu colors (946 bytes, patch)
2011-05-16 00:54 UTC, Benjamin Otte (Company) 		none Details | Review
menus: Use correct classes for menuitems (1.36 KB, patch)
2011-05-16 00:58 UTC, Benjamin Otte (Company) 		none Details | Review
menus: Add hack to properly render prelit menubar labels (996 bytes, patch)
2011-05-16 00:58 UTC, Benjamin Otte (Company) 		none Details | Review
combobox: Remove broken shadow-type declaration (809 bytes, patch)
2011-05-16 00:58 UTC, Benjamin Otte (Company) 		none Details | Review

Description Benjamin Otte (Company) 2011-05-16 00:53:50 UTC 
Here's a bunch of fixes for issues that the parser rewrite found. All those patches should work fine with the current CSS parser, but cause warnings or flat out won't work with the new parser.
Comment 1 Benjamin Otte (Company) 2011-05-16 00:54:23 UTC 
Created attachment 187879 [details] [review]
toolbars: Remove broken property

We were setting an enum to 0, that doesn't do anything.
Comment 2 Benjamin Otte (Company) 2011-05-16 00:54:26 UTC 
Created attachment 187880 [details] [review]
toolbars: Properly seperate toolbar classes from toolbutton classes

Otherwise the CSS won't match with a bugfixed CSS parser
Comment 3 Benjamin Otte (Company) 2011-05-16 00:54:29 UTC 
Created attachment 187881 [details] [review]
menus: Split menu classes from menuitem classes
Comment 4 Benjamin Otte (Company) 2011-05-16 00:54:32 UTC 
Created attachment 187882 [details] [review]
menus: Make sure all menu children use the menu colors

And not as previously, all children that are menus.
Comment 5 Benjamin Otte (Company) 2011-05-16 00:58:08 UTC 
Created attachment 187883 [details] [review]
menus: Use correct classes for menuitems

.menu.check doesn't describe checks of menuitems, but checks of menus.
Comment 6 Benjamin Otte (Company) 2011-05-16 00:58:11 UTC 
Created attachment 187884 [details] [review]
menus: Add hack to properly render prelit menubar labels
Comment 7 Benjamin Otte (Company) 2011-05-16 00:58:13 UTC 
Created attachment 187885 [details] [review]
combobox: Remove broken shadow-type declaration

enum properties cannot be specified as ints
Comment 8 Cosimo Cecchi 2011-05-23 14:02:19 UTC 
This is fixed for git master now.