After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 650150 - FTBFS because vinagre uses both gettext and intltool
FTBFS because vinagre uses both gettext and intltool
Status: RESOLVED FIXED
Product: vinagre
Classification: Applications
Component: general
git master
Other Linux
: Normal major
: ---
Assigned To: vinagre-maint
vinagre-maint
Depends on:
Blocks:
 
 
Reported: 2011-05-13 23:06 UTC by Jeremy Bicha
Modified: 2011-05-24 00:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
buildlog (29.94 KB, application/octet-stream)
2011-05-13 23:06 UTC, Jeremy Bicha
Details
buildlog-dso (133.93 KB, application/octet-stream)
2011-05-14 12:06 UTC, Jeremy Bicha
Details

Description Jeremy Bicha 2011-05-13 23:06:01 UTC
Created attachment 187797 [details]
buildlog

I am attempting to build Vinagre 3.0.1 on my Ubuntu 11.10 development computer except I get the following error:

"config.status: error: po/Makefile.in.in was not created by intltoolize."

I think this is because intltool 0.40.5 or higher does not like to work on a file if gettext worked on it first. Perhaps you only need to use intltool to generate these files.
Comment 1 David King 2011-05-14 03:17:22 UTC
Jeremy, it seems that you need to check your configure options, as I guess that you copied the Debian packaging from a 2.30 version of Vinagre? Some of the options to the configure script have changed, so you should check './configure --help' for an up-to-date list.

The problem appears to stem from your use of autoreconf during the build phase (dh_autoreconf, see http://manpages.ubuntu.com/manpages/oneiric/man1/dh_autoreconf.1.html), which runs ‘autopoint’. That should not be needed unless you are patching configure.ac or Makefile.am. If you are applying patches (the Launchpad integration patch, 01_lpi.patch would touch one or both of those files, I guess), then you should be able to fix the use of autopoint by configuring with the ‘AUTOPOINT’ environment variable set to ‘intltoolize’, for example:

AUTOPOINT=intltoolize autoreconf

or some other method with dh_autoreconf, see the documentation above.

In terms of using gettext and intltool macros in configure.ac, this is recommended by the intltool documentation (which is, however, very out of date), see the file I18N-HOWTO in the intltool tarball, or in /usr/share/doc. Let me know if this solves your problem.
Comment 2 Jeremy Bicha 2011-05-14 12:06:49 UTC
Created attachment 187808 [details]
buildlog-dso

Thanks, David, this is how I fixed my original issue:

DEB_CONFIGURE_EXTRA_FLAGS += --enable-ssh \
                             --disable-scrollkeeper \
                             --without-panelapplet \
                             VNC_CFLAGS=-I/usr/include/gtk-vnc-2.0

DEB_DH_AUTORECONF_ARGS += AUTOPOINT=intltoolize

I've got a bit further in the build but now I'm getting a DSO error and I haven't been able to figure out how to work around it:

/usr/bin/ld: ./.libs/libvinagre.a(vinagre-tube-handler.o): undefined reference to symbol 'dbus_g_type_struct_get'
/usr/bin/ld: note: 'dbus_g_type_struct_get' is defined in DSO /usr/lib64/libdbus-glib-1.so.2 so try adding it to the linker command line

New build log attached.
Comment 3 Sebastien Bacher 2011-05-17 13:49:00 UTC
The issue seems similar to https://bugzilla.gnome.org/show_bug.cgi?id=627789, are you sure both are required? it seems the gettext macros should be dropped
Comment 4 Sebastien Bacher 2011-05-17 13:53:21 UTC
dropping those lines makes it work there:

"AM_GNU_GETTEXT([external])
AM_GNU_GETTEXT_VERSION([0.17])"
Comment 5 Sebastien Bacher 2011-05-18 09:24:01 UTC
the intltool maintainer confirmed that if the intltool macro is being used the gettext one shouldn't since they conflict and intltool should do what is needed
Comment 6 David King 2011-05-19 04:51:55 UTC
Sebastian, has the intltool documentation been updated? I am using 0.41.1. I found a bug report:

https://bugs.edge.launchpad.net/intltool/+bug/654918

but it appears that the documentation still recommends the use of both gettext and intltool macros in configure.ac:

http://bazaar.launchpad.net/~intltool/intltool/trunk/view/head:/doc/I18N-HOWTO
Comment 7 David King 2011-05-19 04:55:37 UTC
(In reply to comment #2)

Jeremy, you probably want to apply:

http://git.gnome.org/browse/vinagre/commit/?h=gnome-3-0&id=b94ef0d49c7d2d4b8ab4f8d03fa25d9def696c6f

from the gnome-3-0 branch, as it fixes the issue that you describe. If you are curious, Diego Pettenò has a good explanation:

http://blog.flameeyes.eu/2010/11/26/it-s-not-all-gold-that-shines-why-underlinking-is-a-bad-thing
Comment 8 Danilo Segan 2011-05-19 09:22:56 UTC
Yes, indeed, as Rodney (my intltool comaintainer) says in comment #3 of the above bug, one should not use both macros: https://bugs.launchpad.net/intltool/+bug/654918/comments/3

He also just filed a new bug about updating the documentation: https://bugs.launchpad.net/intltool/+bug/784191
Comment 9 Jeremy Bicha 2011-05-20 23:18:00 UTC
David, thanks for the help. I got Vinagre to build ok; in Ubuntu we're using a very simple patch (basically comment 4) to work around this bug.
Comment 10 David King 2011-05-24 00:20:23 UTC
(In reply to comment #8)
In that case, this is fixed in commit ba4174a1b7eb27b76828a15e6fb6a43b597ae6d2 and c6c5015dbd92e81856577a47d922d31ac85c7031 in master and gnome-3-0 branches, respectively.