After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 650061 - examples make use of deprecated function g_thread_init()
examples make use of deprecated function g_thread_init()
Status: RESOLVED FIXED
Product: librest
Classification: Platform
Component: other
git master
Other Linux
: Normal normal
: ---
Assigned To: librest-maint
librest-maint
Depends on:
Blocks:
 
 
Reported: 2011-05-12 20:29 UTC by Davide Italiano
Modified: 2012-06-16 09:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (2.96 KB, patch)
2011-05-12 20:29 UTC, Davide Italiano 		none Details | Review
Drop obsolete g_thread_init() (6.88 KB, patch)
2012-01-03 14:07 UTC, Martin Pitt 		committed Details | Review

Description Davide Italiano 2011-05-12 20:29:49 UTC 
Created attachment 187736 [details] [review]
patch

In example g_thread_init(NULL) is called together with g_type_init(). .Since version 2.24 g_type_init() also initializes the thread system, so calling also g_thread_init(NULL) is not required and could also be not safe.
Comment 1 Martin Pitt 2012-01-03 13:55:12 UTC 
Confirming. Note that the patch description should say "since 2.24", not "since 2.2".
Comment 2 Martin Pitt 2012-01-03 14:07:29 UTC 
Created attachment 204498 [details] [review]
Drop obsolete g_thread_init()

This patch also covers the remaining instances in the tests, and bumps the glib requirement accordingly.
Comment 3 Christophe Fergeau 2012-06-07 09:42:34 UTC 
Seems good to me, Ross ?
Comment 4 Ross Burton 2012-06-07 13:54:18 UTC 
Review of attachment 204498 [details] [review]:

Push it.
Comment 5 Christophe Fergeau 2012-06-16 09:36:37 UTC 
Attachment 204498 [details] pushed as 7ca54a3 - Drop obsolete g_thread_init()